Properly handle unreachable instructions and null stack entries #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enigma/src/main/java/cuchaz/enigma/analysis/index/IndexReferenceVisitor.java
Outdated
Show resolved
Hide resolved
Contributor
|
Did you test that your PR fixes #565? That looks like a slightly different stack trace to me. |
Co-authored-by: Joseph Burton <burtonjae@hotmail.co.uk>
Contributor
Author
|
I was able to reproduce something a near-identical stacktrace (except maybe line numbers) when indexing galimulator, so from my point of view it should fix it. Of course, galimulator isn't an old version of minecraft, so take it with a grain of salt. |
Earthcomputer
approved these changes
Oct 18, 2025
Contributor
|
I confirmed that Minecraft 1.16.5 is also fixed by this PR |
modmuss50
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #565
Closes #570
This might very well be an instance of suppressing the symptoms rather than the root cause, so if someone has a better idea do tell (I'm not super acquainted with asm's analyzer API).