Added GM:OnDuplicated(ent, entDupeTable)

[Grocel]

Works like ENTITY:OnDuplicated(ent, entDupeTable) but doesn't require adding/detouring ent.OnDuplicated on OnEntityCreated calls for addon-foreign entities.

This adds a easy way to add generic logic early to the duplication life cycle. It is called a way before duplicator.RegisterEntityModifier() added callers are being iterated. The new hook also reduces the risk of conflicts caused by detours of pre-existing ent.OnDuplicated code.

Test script:

if SERVER then
    hook.Add("OnDuplicated", "Test", function(ent, entTable)
        print(ent)
        PrintTable(entTable)
    end)
end

[marchc1]

Would be very useful to have this hook coming from the perspective of a developer on ACF-3. We've wanted something like this for a while, iirc

[thegrb93]

The name should be something more like PostDuplicatorPaste which is more consistent with the PostEntityPaste hook.

[Grocel]

The name should be something more like PostDuplicatorPaste which is more consistent with the PostEntityPaste hook.

Don't think it would reflect what it does. It is called in the beginning if the duplication process (even before ent:Spawn()), not the end of it. The name is being picked as an analog to of the entity's hook name.

However what do you think of naming it OnEntityDuplicated instead?

[thegrb93]

Oh I thought you were adding a post paste hook, which gmod also needs. Nvm

[Grocel]

Oh I thought you were adding a post paste hook, which gmod also needs. Nvm

If this one gets of the ground, I can submit PRs adding those for both projects as well.

[robotboy655]

My concern with this is cost of execution. This is already a problem for large dupes.

A post-duplication hook would be a safer bet, even if it would be more annoying to work with to modify a single entity entry.

[Grocel]

My concern with this is cost of execution. This is already a problem for large dupes.

A post-duplication hook would be a safer bet, even if it would be more annoying to work with to modify a single entity entry.

1. It should be O(n) for entity count of dupe, or O(1) for a single entity. Similar how ent.OnDuplicated() already is.
2. Adding a post hook after dupe would not do this justice as it is specifically asked to have a hook that runs early on the pipeline and per entity.
3. A hook running in post is something I would like to make in an separate PR.

Can we ensure that there is no misunderstanding between your and my idea?

[marchc1]

My concern with this is cost of execution. This is already a problem for large dupes.

A post-duplication hook would be a safer bet, even if it would be more annoying to work with to modify a single entity entry.

I think it would be worth actually profiling the cost vs a hypothetical before coming to this conclusion.