Fix sizing for full screen while maximized#187
Open
boxrocket6803 wants to merge 3 commits intoFacepunch:masterfrom
Open
Fix sizing for full screen while maximized#187boxrocket6803 wants to merge 3 commits intoFacepunch:masterfrom
boxrocket6803 wants to merge 3 commits intoFacepunch:masterfrom
Conversation
viewport no longer gets cut off when fullscreened in a maximized window
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two issues with the full screen editor functionality: viewport edges being cut off when the editor window is maximized, and event registration timing that prevented proper sizing on the first full screen of a session.
Changes:
- Moved
EditorEvent.RegisterfromClear()method to constructor to ensure events are registered at object creation - Relocated maximized window adjustment logic from
SetWidget()toGetTargetPosition()andGetTargetSize()to prevent it from being reset each frame
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The edge of the viewport has been getting cut off in full screen for a while, the code to fix that was already there but it was in the wrong place so it got reset each frame.
FullScreenManager was also registering for editor events in the wrong place so the position and size of the widget wouldn't update on the first full screen of the session (it was registering when full screen was cleared, this just registers it in the constructor).