More consistently clear ListView hovered item#189
Open
boxrocket6803 wants to merge 2 commits intoFacepunch:masterfrom
Open
More consistently clear ListView hovered item#189boxrocket6803 wants to merge 2 commits intoFacepunch:masterfrom
boxrocket6803 wants to merge 2 commits intoFacepunch:masterfrom
Conversation
most notably consistently clears the status bar file path from asset browser
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the ListView's hovered item state would get stuck when the mouse left the widget without triggering the OnMouseMove event. This commonly occurred when moving the mouse to a different window, causing the status bar to display stale information that blocked console output.
Changes:
- Added automatic hover state cleanup in the frame update loop to detect when the mouse is no longer over the widget
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status bar path that asset browser creates when hovering over items has a bad habit of getting stuck there and blocking the console output I want to see, if the mouse left the item in such a way that OnMouseMove didn't get called (most commonly by moving onto a different window) the hovered item would get stuck. This manually clears the hovered item if the mouse isn't over the widget.