Open
Conversation
This commit adds a blender style trackball and view space rotation to all rotate gizmos. This is a breaking change to anything that currently uses the rotate method as you now must use the output directly rather than multiply it. Also added a method to get distance vector, not sure why it's only a float.
DrakeFruit
force-pushed
the
Better-Gizmos
branch
from
dd4fdaa to
cd92464
Compare
Contributor
Author
Screencast_20260208_145019.mp4fixed the inconsistency, might need to multiply rotation speed by 1.5 or something, feels a little slow |
Contributor
Author
|
API change seems to break my summer cottage, anyone have some advice on this? I don't think it's possible to not break the API here @bakscratch |
Contributor
I don't really know what any of that means, but you also removed the snapping too? Just looking at the code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a trackball and view-space rotation gizmo, similar to how blender does it
Motivation & Context
I'd like to rotate multiple axis at once, or rotate something in view-space. This is really useful for mapping in general and is part of getting feature parity with hammer and other 3D applications.
Fixes:
Implementation Details
Unfortunately to get this working I had to swap the output type of gizmocontrols.rotate to a rotation instead of angles. This is a breaking change for anything that uses this method but I have gone ahead and adjusted any engine code that uses this to reflect the change.
I've also added a gizmo method for a distance vector, the only existing method returned a float.
Screenshots / Videos (if applicable)
Screencast_20260206_125638.webm
Checklist