Datastore modules fix - Master credentials and connection_string #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oss datastore modules.
ishaankalra
requested changes
Nov 24, 2025
ishaankalra
requested changes
Nov 25, 2025
ishaankalra
requested changes
Dec 2, 2025
ishaankalra
requested changes
Dec 2, 2025
ishaankalra
requested changes
Dec 16, 2025
| # Network configuration | ||
| db_subnet_group_name = local.is_import ? var.instance.spec.imports.subnet_group_name : aws_docdb_subnet_group.main[0].name | ||
| vpc_security_group_ids = local.is_import ? [var.instance.spec.imports.security_group_id] : [aws_security_group.documentdb[0].id] | ||
| db_subnet_group_name = local.is_import ? var.instance.spec.imports.subnet_group_name : aws_docdb_subnet_group.main.name |
Contributor
There was a problem hiding this comment.
try to import it to tf state
Contributor
There was a problem hiding this comment.
deploy the resource initially through facets, state rm it, then add the import attributes, and do the release to import the resource back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Correct Password Reference & Standardize
connection_stringOutput Across Datastore ModulesThis PR applies a targeted fix to ensure consistency and correctness across all datastore modules:
Updates Included
passwordoutput references.connection_stringoutput format across MySQL, Postgres, Mongo, and Redis modules.Purpose:
Improve reliability of module outputs and ensure downstream consumers receive consistent and correctly formatted connection values.