cert-manager and external-dns #92
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omendra-tomar
force-pushed
the
external-dns-cert-manager-refactor
branch
from
dcc95af to
7e0c3e0
Compare
This commit fixes two critical issues in the Azure external-dns module: 1. **Azure Credentials Handling**: - Removed dependency on non-existent facets-tenant-dns secret - Now uses cloud_account input directly for Azure client_secret - Added azure.json ConfigMap for kubernetes-sigs chart compatibility - Mounted ConfigMap as volume at /etc/kubernetes/azure.json 2. **Priority Class Configuration**: - Made priority class configurable via advanced.externaldns.priority_class_name - Defaults to "facets-critical" - Users can override to use existing priority classes These changes ensure: - External-DNS pods can start successfully - Azure credentials are properly provided to the Helm chart - Cert-manager can use the credentials for DNS-01 validation - Priority class is flexible and doesn't cause pod creation failures 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.