Skip to content

Conversation

@RoguedBear
Copy link
Contributor

@RoguedBear RoguedBear commented Feb 14, 2025

Description

adds outputs for vpc for all 3 clouds.

This pr will also unblock #248

Related issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have created feat/bugfix branch out of develop branch
  • Code passes linting/formatting checks
  • Changes to resources have been tested in our dev environments
  • I have made corresponding changes to the documentation

Testing

Reviewer instructions

@RoguedBear RoguedBear changed the title Add output facets for AWS, Azure, and GCP VPCs Add outputs facets.yaml for AWS, Azure, and GCP VPCs Feb 17, 2025
@RoguedBear RoguedBear marked this pull request as ready for review February 17, 2025 08:35
@pramodh-ayyappan pramodh-ayyappan merged commit db366cb into develop Feb 18, 2025
@pramodh-ayyappan pramodh-ayyappan deleted the vpc_outputs branch February 18, 2025 12:43
pramodh-ayyappan pushed a commit that referenced this pull request Mar 7, 2025
* Add output facets for AWS, Azure, and GCP VPCs

* Add outputs for Azure, AWS, and GCP VPCs in index.json

* Remove gitRef entries for Azure, AWS, and GCP VPCs in outputs.index.json
pramodh-ayyappan pushed a commit that referenced this pull request Mar 12, 2025
* Add output facets for AWS, Azure, and GCP VPCs

* Add outputs for Azure, AWS, and GCP VPCs in index.json

* Remove gitRef entries for Azure, AWS, and GCP VPCs in outputs.index.json
pramodh-ayyappan added a commit that referenced this pull request Mar 12, 2025
* if price is 0, exclude from dataset (#174)

* if price is 0, exclude from dataset

* removed .DS_Store

* added generated files

* removed incorrect files (#176)

* update gitref for sqs

* [S73] Feature: Per-Instance Artifactories Module (#210)

* Added artifactories facets modules

* added schema

* updated spec

* changed type to string

* updated to null

* introduced indentation

* updated spec

* updated spec to have include_all false as default

* updated type from bool to boolean

* Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

This reverts commit 71471b7.

* if price is 0, exclude from dataset (#174)

* if price is 0, exclude from dataset

* removed .DS_Store

* added generated files

* removed incorrect files (#176)

* [S73] Feature: Per-Instance Artifactories Module (#210)

* Added artifactories facets modules

* added schema

* updated spec

* changed type to string

* updated to null

* introduced indentation

* updated spec

* updated spec to have include_all false as default

* updated type from bool to boolean

* Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

This reverts commit 71471b7.

* [S73] Feature: Per-Instance Artifactories Module (#215)

* Added artifactories facets modules

* added schema

* updated spec

* changed type to string

* updated to null

* introduced indentation

* updated spec

* updated spec to have include_all false as default

* updated type from bool to boolean

* added intent level output

* Artifactories Terraform Module (#228)

* added artifactories module

* updates to vault module

* removed facets yaml outputs

* added gitignore files

* Cleaned up ignored files

* Cleaned up ignored files

* Cleaned up ignored files

* added artifactories module

* updated to vault facets.yaml

* terraform fmt

* deleted zip_modules.py

* updated module source

* Add 0.2 version of database users part 2 (#229)

* Add 0.2 version of postgres_user default flavor

* Add 0.2 version of mysql_user default flavor

* add depends on database-operator for postgres user

* Add 0.2 version of kafka_user default flavor

* Remove input from sample

* update escaping for *

* define and add output for kafka

* fix output string

* fix output for all users

* use updated path for utility modules

* remove depends on block from facets.yaml

* remove versions.tf

* updated to work with github app

(cherry picked from commit 122c9dc28b355bfe612e98f026decf2195beb507)

* Innersourcing workflows (#230)

* added zip modules py

* updated the print statement

* modified the print message in zip_modules.py

* Implement concurrent zipping and uploading to S3 in zip_modules.py

* Update publish workflow to run on custom runner and assume dependencies are installed.

* Move zip_modules.py to workflows folder.

* removed comments

* added support for optional variable branch

* Innersourcing workflows update (#231)

* added zip modules py

* updated the print statement

* modified the print message in zip_modules.py

* Implement concurrent zipping and uploading to S3 in zip_modules.py

* Update publish workflow to run on custom runner and assume dependencies are installed.

* Move zip_modules.py to workflows folder.

* removed comments

* added support for optional variable branch

* Add dependency installation step to publish workflow.

* added support for optional variable branch

* added support for install dependencies

* Add S3 bucket name to zip_modules.py.

* updated workflow and create a new directory to zip modules

* updated workflow and create a new directory to zip modules

* updated workflow and create a new directory to zip modules

* Update requirements.txt to include only necessary external dependencies.

* posting success message to slack channel

* removed the development branch support

* changes

* changes

* deleted zip modules previous file

* Update publish workflow to use S3_BUCKET_NAME from workflow variable.

* Update zip_modules.py to use S3 bucket name from environment variable.

* Preview modules (#239)

* Updated preview.yml to read token secret name from TokenRef

* Updated preview.yml to read token secret name from TokenRef

* Updated preview.yml to append -github_ref to the version in facets.yaml

* if price is 0, exclude from dataset (#174)

* if price is 0, exclude from dataset

* removed .DS_Store

* added generated files

* removed incorrect files (#176)

* Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

This reverts commit 71471b7.

* [S73] Feature: Per-Instance Artifactories Module (#215)

* Added artifactories facets modules

* added schema

* updated spec

* changed type to string

* updated to null

* introduced indentation

* updated spec

* updated spec to have include_all false as default

* updated type from bool to boolean

* added intent level output

* Artifactories Terraform Module (#228)

* added artifactories module

* updates to vault module

* removed facets yaml outputs

* added gitignore files

* Cleaned up ignored files

* Cleaned up ignored files

* Cleaned up ignored files

* added artifactories module

* updated to vault facets.yaml

* terraform fmt

* deleted zip_modules.py

* updated module source

* Innersourcing workflows (#230)

* added zip modules py

* updated the print statement

* modified the print message in zip_modules.py

* Implement concurrent zipping and uploading to S3 in zip_modules.py

* Update publish workflow to run on custom runner and assume dependencies are installed.

* Move zip_modules.py to workflows folder.

* removed comments

* added support for optional variable branch

* Innersourcing workflows update (#231)

* added zip modules py

* updated the print statement

* modified the print message in zip_modules.py

* Implement concurrent zipping and uploading to S3 in zip_modules.py

* Update publish workflow to run on custom runner and assume dependencies are installed.

* Move zip_modules.py to workflows folder.

* removed comments

* added support for optional variable branch

* Add dependency installation step to publish workflow.

* added support for optional variable branch

* added support for install dependencies

* Add S3 bucket name to zip_modules.py.

* updated workflow and create a new directory to zip modules

* updated workflow and create a new directory to zip modules

* updated workflow and create a new directory to zip modules

* Update requirements.txt to include only necessary external dependencies.

* posting success message to slack channel

* removed the development branch support

* changes

* changes

* deleted zip modules previous file

* Update publish workflow to use S3_BUCKET_NAME from workflow variable.

* Update zip_modules.py to use S3 bucket name from environment variable.

* Preview modules workflow changes (#243)

* fix for reading secret

* fix for reading secret

* updated to single quotes

* updated the logic  of reading the control planes json

* updated the logic  of creating the control planes json

* Updated preview.yml to work with control_planes.json

* Updated preview.yml to use format function for dynamic token retrieval

* added TOKEN_REF_NAME

* update to get the module directory path

* using all secrets

* added a cat command

* updated the jq commands

* updating the sample version as well

* updating the sample version as well

* updated the script to fail if any command failed

* testing fail scenario

* Revert "testing fail scenario"

This reverts commit 0d25918.

* added a few assertions

* updated the variables name

* added github workflows for validate bootrapper (#245)

* Validate bootstraper (#246)

* added github workflows for validate bootrapper

* added step for trigger validate-bootstrapper in publish.yml

* changed the trigger name

* using workflow_runs

* using workflow_runs conclusion

* Github actions fixes (#249)

* github actions fixes

* changed the env variable name

* Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

This reverts commit 71471b7.

* [S73] Feature: Per-Instance Artifactories Module (#210)

* Added artifactories facets modules

* added schema

* updated spec

* changed type to string

* updated to null

* introduced indentation

* updated spec

* updated spec to have include_all false as default

* updated type from bool to boolean

* Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

This reverts commit 71471b7.

* [S73] Feature: Per-Instance Artifactories Module (#215)

* Added artifactories facets modules

* added schema

* updated spec

* changed type to string

* updated to null

* introduced indentation

* updated spec

* updated spec to have include_all false as default

* updated type from bool to boolean

* added intent level output

* Validate bootstraper (#246)

* added github workflows for validate bootrapper

* added step for trigger validate-bootstrapper in publish.yml

* changed the trigger name

* using workflow_runs

* sync with innersourcing

* Config modules for db users (#255)

* [S73] Feature: Per-Instance Artifactories Module (#210)

* Added artifactories facets modules

* added schema

* updated spec

* changed type to string

* updated to null

* introduced indentation

* updated spec

* updated spec to have include_all false as default

* updated type from bool to boolean

* Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

This reverts commit 71471b7.

* [S73] Feature: Per-Instance Artifactories Module (#210)

* Added artifactories facets modules

* added schema

* updated spec

* changed type to string

* updated to null

* introduced indentation

* updated spec

* updated spec to have include_all false as default

* updated type from bool to boolean

* Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

This reverts commit 71471b7.

* feat: Add ecs_service intent for managing containers in Amazon ECS

* [S73] Feature: Per-Instance Artifactories Module (#215)

* Added artifactories facets modules

* added schema

* updated spec

* changed type to string

* updated to null

* introduced indentation

* updated spec

* updated spec to have include_all false as default

* updated type from bool to boolean

* added intent level output

* add database operator as per instance module

* add database operator as necessary input for postgres user

* add crossplane as per instance module

* add crossplane as necessary input in mysql user

* update the regex for crossplane

* add mongodb auth operator as per instance module

* add mongodb auth operator as necessary input in mongo user

* update description

* update output string

* add database operator intent in index.json

* update sample

* update sample

* update description mongo user

* formatting changes

* move values to spec and use facets as default namespace

* fix display name and description in mongo user

* added back inputs

---------

Co-authored-by: pramodh-ayyappan <[email protected]>
Co-authored-by: rohit (aider) <[email protected]>
Co-authored-by: pramodh-ayyappan <[email protected]>

* Add outputs facets.yaml for AWS, Azure, and GCP VPCs (#263)

* Add output facets for AWS, Azure, and GCP VPCs

* Add outputs for Azure, AWS, and GCP VPCs in index.json

* Remove gitRef entries for Azure, AWS, and GCP VPCs in outputs.index.json

* Change k8s cloud to kubernetes in monitoring modules (#270)

* spec.runtime.metrics for service(deploy,sts) (#273)

* removed xui toggle skip

* removed xui toggle skip sts

* fix(intent/ingress): add outputs for ingress intent (#275)

* Intent type fixes (#276)

* fix intent types

* resolved commnents and changed the intent type for api-gateway, event bus, eventbridge

* changed to Secret management

---------

Co-authored-by: Rauneet <[email protected]>

* Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

This reverts commit 71471b7.

* [S73] Feature: Per-Instance Artifactories Module (#210)

* Added artifactories facets modules

* added schema

* updated spec

* changed type to string

* updated to null

* introduced indentation

* updated spec

* updated spec to have include_all false as default

* updated type from bool to boolean

* Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

This reverts commit 71471b7.

* Innersourcing workflows (#230)

* added zip modules py

* updated the print statement

* modified the print message in zip_modules.py

* Implement concurrent zipping and uploading to S3 in zip_modules.py

* Update publish workflow to run on custom runner and assume dependencies are installed.

* Move zip_modules.py to workflows folder.

* removed comments

* added support for optional variable branch

* Innersourcing workflows update (#231)

* added zip modules py

* updated the print statement

* modified the print message in zip_modules.py

* Implement concurrent zipping and uploading to S3 in zip_modules.py

* Update publish workflow to run on custom runner and assume dependencies are installed.

* Move zip_modules.py to workflows folder.

* removed comments

* added support for optional variable branch

* Add dependency installation step to publish workflow.

* added support for optional variable branch

* added support for install dependencies

* Add S3 bucket name to zip_modules.py.

* updated workflow and create a new directory to zip modules

* updated workflow and create a new directory to zip modules

* updated workflow and create a new directory to zip modules

* Update requirements.txt to include only necessary external dependencies.

* posting success message to slack channel

* removed the development branch support

* changes

* changes

* deleted zip modules previous file

* Update publish workflow to use S3_BUCKET_NAME from workflow variable.

* Update zip_modules.py to use S3 bucket name from environment variable.

* Innersourcing workflows (#230)

* added zip modules py

* updated the print statement

* modified the print message in zip_modules.py

* Implement concurrent zipping and uploading to S3 in zip_modules.py

* Update publish workflow to run on custom runner and assume dependencies are installed.

* Move zip_modules.py to workflows folder.

* removed comments

* added support for optional variable branch

* added github workflows for validate bootrapper (#245)

* Github actions fixes (#249)

* github actions fixes

* changed the env variable name

* Reapply "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

This reverts commit 27a1abc.

* adding back removed artifactory changes

* type fix

* added back artifactories inputs

* innersourcing sync with master

---------

Co-authored-by: Shashwat Pathak <[email protected]>
Co-authored-by: Jayant <[email protected]>
Co-authored-by: Ishaan Kalra <[email protected]>
Co-authored-by: Sanmesh Kakade <[email protected]>
Co-authored-by: ishaankalra <[email protected]>
Co-authored-by: rohit (aider) <[email protected]>
Co-authored-by: Jayant <[email protected]>
Co-authored-by: Anuj Hydrabadi <[email protected]>
Co-authored-by: aditya-facets <[email protected]>
Co-authored-by: rauneetverma <[email protected]>
Co-authored-by: Rauneet <[email protected]>
rr0hit pushed a commit that referenced this pull request Jun 18, 2025
* Add output facets for AWS, Azure, and GCP VPCs

* Add outputs for Azure, AWS, and GCP VPCs in index.json

* Remove gitRef entries for Azure, AWS, and GCP VPCs in outputs.index.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants