Update to spring-boot 4 #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates grpcmock so it can be used with spring-boot 4. I also bumped
spring-grpcdependency to 1.0.0, but this applies to an example project only.Two main changes applied:
PropertyMappingmoved to another package.GrpcMockConfigurationdoesn't implementSmartLifecyclenow, it usesDisposableBeanto stop the GRPC server. This is needed to support context pausing in tests, implemented in spring framework 7. Now, spring will may pause a context during tests execution, if the context is needed, and resume it before using the next time.DefaultListableBeanFactory. I believe the test is even cleaner now.I'm not sure how you'd like to proceed with the change, as it makes the project incompatible with spring-boot 3 due to the first change. Would you drop spring-boot 3 support now?