Skip to content

fix: Widen YawnProjections args to YawnDef from YawnTableDef#113

Merged
jwoliver-faire merged 1 commit intomainfrom
james/fix/count-distinct
Mar 2, 2026
Merged

fix: Widen YawnProjections args to YawnDef from YawnTableDef#113
jwoliver-faire merged 1 commit intomainfrom
james/fix/count-distinct

Conversation

@jwoliver-faire
Copy link
Contributor

@jwoliver-faire jwoliver-faire commented Mar 2, 2026

Changes

Fixes #114

Widens YawnProjections functions to YawnDef<SOURCE, *>.YawnColumnDef<F> .
Should be backwards compatible since it's a wider type, all existing usages satisfy it.

Usage

  val count = session.project(BookTable) { books ->
      val notes = addIsNotNull(books.notes)
      project(YawnProjections.count(notes))
  }.uniqueResult()!!

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jwoliver-faire jwoliver-faire marked this pull request as ready for review March 2, 2026 22:23
@faire-pr-bot-app
Copy link

Looks like the following requested reviewers are unavailable:

  • QuinnB73: :meow_sick: Sick, slow to respond + wfh

Copy link
Collaborator

@QuinnB73 QuinnB73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwoliver-faire jwoliver-faire merged commit 96bdb44 into main Mar 2, 2026
9 checks passed
@jwoliver-faire jwoliver-faire deleted the james/fix/count-distinct branch March 2, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YawnProjection arguments are too narrow

2 participants