feat: Add CreateOntologyStep import to ontology.py#176
feat: Add CreateOntologyStep import to ontology.py#176galshubeli merged 2 commits intoFalkorDB:mainfrom
Conversation
📝 WalkthroughWalkthroughAdded the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
graphrag_sdk/ontology.py (1)
10-80: Use the newly imported CreateOntologyStep directly.Right now the added import is unused, and
Ontology.from_sourcesstill callsgraphrag_sdk.CreateOntologyStep(Line 75). If the package doesn’t expose that symbol, the original error persists. Consider using the directly imported class.✅ Suggested fix
- step = graphrag_sdk.CreateOntologyStep( + step = CreateOntologyStep( sources=sources, ontology=Ontology(), model=model, hide_progress=hide_progress, )
Fix: CreateOntologyStep import for Ontology.from_sources
This PR addresses an issue where the
Ontology.from_sourcesmethod was failing due to a missing import forCreateOntologyStep. As a result, the "Creating Ontologies" example provided in theREADME.md(lines 143-146) was not working as expected.The fix involves adding the necessary import statement for
CreateOntologyStepfromgraphrag_sdk.steps.create_ontology_stepinto thegraphrag_sdk/ontology.pyfile. This resolves the import error and allows the ontology creation process to function correctly as described in the documentation.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.