-
Notifications
You must be signed in to change notification settings - Fork 7
Add connection pool configuration documentation to README #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
…AndPort Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
=========================================
Coverage 73.13% 73.13%
Complexity 265 265
=========================================
Files 25 25
Lines 871 871
Branches 106 106
=========================================
Hits 637 637
Misses 172 172
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Extends README with documentation for customizing JedisPool configuration via
DriverImpl(Pool<Jedis>)constructor.Changes
Added pool configuration guidelines section:
maxTotal,maxIdle,minIdle,maxWaitparameter explanationsmaxIdle = maxTotal / 4for resource/responsiveness balanceFour configuration examples:
JedisClientConfigwith credentials andHostAndPort(64/16/4)SSLSocketFactory(64/16/4)Example Usage
All examples verified against Jedis 6.2.0.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.