Bump next-themes from 0.3.0 to 0.4.6 in /app #319
Conversation
dependabot
bot
added
dependencies
Completed Working on "Code Review"✅ Completed Code Review Publishing: No chunk files found, added one info comment on unused dependency and submitted PR review with REQUEST_CHANGES. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
|
No review chunk files were discovered, so no inline comments were posted. |
![overcut-ai[bot]](https://avatars.githubusercontent.com/in/1367736?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for the dependency bump! While reviewing I noticed next-themes still isn’t referenced anywhere in the codebase, so upgrading it doesn’t give us any benefit but continues to ship an unused package. Please either remove the dependency or add the missing usage/tests to justify keeping it.
| "input-otp": "^1.4.2", | ||
| "lucide-react": "^0.462.0", | ||
| "next-themes": "^0.3.0", | ||
| "next-themes": "^0.4.6", |
There was a problem hiding this comment.
This bump keeps next-themes in the manifest, but the dependency still isn’t used anywhere in the repo (searching for next-themes, ThemeProvider, or useTheme only returns the package manifests). Shipping an unused dependency increases bundle size and attack surface without giving us any functionality. Instead of upgrading it, can we remove the package or add the missing usage/tests so it’s justified?
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/app/staging/next-themes-0.4.6
branch
from
8773ae1 to
db4606f
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/app/staging/next-themes-0.4.6
branch
3 times, most recently
from
c182946 to
723be73
Compare
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/app/staging/next-themes-0.4.6
branch
from
723be73 to
b2f7b2f
Compare
|
@dependabot recreate |
Bumps [next-themes](https://github.com/pacocoursey/next-themes) from 0.3.0 to 0.4.6. - [Release notes](https://github.com/pacocoursey/next-themes/releases) - [Commits](pacocoursey/next-themes@v0.3.0...v0.4.6) --- updated-dependencies: - dependency-name: next-themes dependency-version: 0.4.6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/app/staging/next-themes-0.4.6
branch
from
b2f7b2f to
4776767
Compare
Bumps next-themes from 0.3.0 to 0.4.6.
Release notes
Sourced from next-themes's releases.
... (truncated)
Commits
3a43743v0.4.6f5be1b2fix: add null check for value in updateDOM function to prevent runtime errors...c178917v0.4.5d12996bchore: Fix corepack errors in CI (#342)b77db23Bump the npm_and_yarn group across 1 directory with 7 updates (#341)d3fa4eeBump next from 14.2.10 to 14.2.15 in the npm_and_yarn group across 1 director...ad83567Reduce number of renders by pre-setting resolvedTheme (#338)1b51044fix: map theme to class using ValueObject in injected script (#330)57c0561v0.4.4ae2ab9bfix: infinite loop theme flicker (#329)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)