-
Notifications
You must be signed in to change notification settings - Fork 28
Implement Clean Slate theme system #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Naseem77
commented
Jan 4, 2026
- Replace hardcoded gray colors with theme-aware CSS variables
- Migrate to OKLch color space with Clean Slate theme
- Add Inter, Merriweather, and JetBrains Mono fonts
- Fix theme toggle functionality between light and dark modes
- Improve database connection error messages with user-friendly text
- Replace hardcoded gray colors with theme-aware CSS variables - Migrate to OKLch color space with Clean Slate theme - Add Inter, Merriweather, and JetBrains Mono fonts - Fix theme toggle functionality between light and dark modes - Improve database connection error messages with user-friendly text
Completed Working on "Code Review"✅ Workflow completed successfully. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
- BLOCKER: 0, CRITICAL: 0, MAJOR: 6, MINOR: 0, SUGGESTION: 0, PRAISE: 0
- Key themes:
- Theme toggling and Tailwind dark variants are out of sync, so dark-mode utilities never activate and persisted
systempreferences now map to undefined tokens. - The Clean Slate token implementation introduces build/runtime regressions (unsupported
@themedirective, loss of/alphautilities, and flash of the light palette before JS runs). - Database connection UX still discards backend-provided error text for most HTTP failures, undermining the friendlier messaging goal.
- Theme toggling and Tailwind dark variants are out of sync, so dark-mode utilities never activate and persisted
Next steps
- Restore
.darkclass toggling or update Tailwind to honor[data-theme='dark'], and sanitize stored theme values before applying them. - Define tokens in a way compatible with Tailwind 3 alpha utilities or upgrade the toolchain before using
@theme, and ensure dark palette defaults to avoid flashes. - Parse JSON error bodies for all non-OK statuses in
DatabaseModaland only fall back to generic messages if none are provided.