Merged
Conversation
* use PyDecodeLocale to decode unicode rather than mbstowcs
* windows platform able to get correct encoding char only when use `wmain` to build * for supporting wmain & main in code, use macro define custom `_XXXX` to support it at the same logic * wmain need to use wchar_t version * main need to use char version
* PySys_SetArgv is deprecated since python 3.11. It's original behavior will insert script's directory into sys.path. It's replace by PyConfig, but PyConfig only update sys.path when executing Py_Main or Py_RunMain. So it's better to update sys.path by pyconcrete.
Falldog
force-pushed
the
fix/issue-124-unicode-argv
branch
from
895cc70 to
741e164
Compare
[why] PyObject_CallOneArg only support on 3.9+ [how] Replace it by PyObject_CallObject
[why] PyConfig added at 3.8 [how] Use original behavior Py_SetProgramName & PySys_SetArgv
Falldog
force-pushed
the
fix/issue-124-unicode-argv
branch
from
630bd4f to
663350d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Fix #124
sys.argvshould support unicode string as argumnetSolution
wmainon Windows platformmainon other platform_XXXXto support it at the same logicNot support platform
Windows Python3.7