Make out of media a mishap and kill SideEffect earlyExit #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamsTheNerd
requested changes
Nov 5, 2024
Member
SamsTheNerd
left a comment
SamsTheNerd
left a comment
There was a problem hiding this comment.
otherwise looks fine to me
Common/src/main/java/at/petrak/hexcasting/api/casting/eval/CastingEnvironment.java
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/castables/ConstMediaAction.kt
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/eval/sideeffects/OperatorSideEffect.kt
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapNotEnoughMedia.kt
Show resolved
Hide resolved
SamsTheNerd
reviewed
Nov 12, 2024
Member
SamsTheNerd
left a comment
SamsTheNerd
left a comment
There was a problem hiding this comment.
code looks fine to me. PR should probably be tested in game (unclear if it was already or not). I'm not doing that rn, but poke me once that's done if I haven't gotten to it myself.
SamsTheNerd
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #769.
Visible behaviour changes from this PR:
Overcasting is more forgiving; Spells that would kill you and still fail no longer kill youOther media overspending also no longer spends all your media