Blocky Chroniclers #796
Blocky Chroniclers #796
Conversation
object-Object
left a comment
object-Object
left a comment
There was a problem hiding this comment.
Some nitpicks, some questions. Otherwise I think it overall looks good, assuming you've tested everything.
| boolean writeable(); | ||
|
|
||
| // a helper for read-only holders | ||
| interface ADIotaHolderReadOnly extends ADIotaHolder{ |
There was a problem hiding this comment.
should there also be a WriteOnly version?
| import net.minecraft.world.phys.Vec3 | ||
|
|
||
| // a silly stupid wrapper for throwing arbitrary badness mishaps (the ones that have a .of(thing, stub) constructor. | ||
| class MishapBad { |
There was a problem hiding this comment.
IMO this should just be a function in ActionUtils or something. Or if it has to be its own class for some reason, it should at least be abstract.
| @Override | ||
| public CompoundTag readIotaTag(){ | ||
| if(pattern == null){ | ||
| return IotaType.serialize(emptyIota()); | ||
| } | ||
| return IotaType.serialize(new PatternIota(pattern)); | ||
| } | ||
|
|
||
| @Override | ||
| public Iota readIota(ServerLevel world) { | ||
| if(pattern == null){ | ||
| return emptyIota(); | ||
| } | ||
| return new PatternIota(pattern); | ||
| } |
There was a problem hiding this comment.
It feels weird for the logic here to be duplicated... not sure how to fix it though.
| @Nullable | ||
| default ADIotaHolder findDataHolder(BlockPos pos, ServerLevel world){ | ||
| return HexAPIImpl.getBlockyIotaHolder(world, pos); | ||
| } | ||
|
|
There was a problem hiding this comment.
It feels kinda weird to put something in IXplatAbstractions if it's not actually different per-platform. I see why it's there, I guess... maybe add a comment justifying it?
| iota: { | ||
| "": "место для хранения йоты", | ||
| read: "место, откуда можно читать йоты", | ||
| write: "место, куда можно записывать йоты", | ||
| readonly: "место, которое будет принимать %s", | ||
| } |
| iota: { | ||
| "": "一个可以存储iota的地方", | ||
| read: "一个可以读出iota的地方", | ||
| write: "一个可以写入iota的地方", | ||
| readonly: "一个能够接受%s的地方", | ||
| } |
| if(!simulate){ | ||
| if(iota instanceof PatternIota pIota){ | ||
| this.pattern = pIota.getPattern(); | ||
| sync(); | ||
| } | ||
| if(iota instanceof NullIota || iota == null){ | ||
| this.pattern = null; | ||
| sync(); | ||
| } | ||
| } | ||
| return iota instanceof PatternIota || iota instanceof NullIota || iota == null; |
There was a problem hiding this comment.
This feels weirdly duplicated, but idk how to fix it (other than moving to Kotlin).
|
|
||
| val burstPos = target.map({ent -> if (ent is ItemEntity) { | ||
| // Special case these because the render is way above the entity | ||
| ent.position().add(0.0, 3.0 / 8.0, 0.0) |
There was a problem hiding this comment.
maybe this logic could be moved to a utility function? eg ParticleSpray.getEntityBurstPos or something
|
I believe Petra was opposed to this? |
|
Moved to https://github.com/object-Object/IoticBlocks since Petra doesn't want it in the base mod. |
Allows chroniclers to read/write blocks.
Blocks can opt in in three ways.
ADIotaProvideron a Block Entity class.IBlockyIotaProvideron a Block class.Option 1 will likely work best in most cases (since data is generally stored in a block entity), but option 2 is good for static reading or for reading that only depends on the environment (like akashic record). Finally, option 3 is provided for cases where you can't implement an interface, such as for another mod's block or for optional hex interop.