Revert #965 #968
Merged
Revert #965 #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" (fix #967) This reverts commit c64e5d7, reversing changes made to 22b7a6f. The changes made in #965 were meant to avoid any impact for addons, but we've since realized that adding an optional argument to a method still breaks mixins targeting that method. This caused a crash with HexxyInTheAlps and may also break other addons. While mixin impacts aren't technically breaking changes, we still don't really want to break an unknown number of addons this close to a release, so we'll resolve this issue by reverting #965 and revisiting this change at a later date.
PoolloverNathan
approved these changes
Nov 20, 2025
Contributor
PoolloverNathan
left a comment
PoolloverNathan
left a comment
There was a problem hiding this comment.
Don't see any issues with this; when's our next breaking change window?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c64e5d7, reversing changes made to 22b7a6f.
The changes made in #965 were meant to avoid any impact for addons, but we've since realized that adding an optional argument to a method still breaks mixins targeting that method. This caused a crash with HexxyInTheAlps and may also break other addons.
While mixin impacts aren't technically breaking changes, we still don't really want to break an unknown number of addons this close to a release, so we'll resolve this issue by reverting #965 and revisiting this change at a later date.