Conversation
gossip/c_event_callbacks.go
Outdated
|
|
||
| // aBFT processing | ||
| return s.engine.Process(e) | ||
| err = s.engine.Process(e) |
There was a problem hiding this comment.
Can you explain why we need to do this refactoring?
gossip/c_block_callbacks.go
Outdated
| _ = metrics.GetOrRegisterMeter("chain/reorg/executes", nil) | ||
| _ = metrics.GetOrRegisterMeter("chain/reorg/add", nil) | ||
| _ = metrics.GetOrRegisterMeter("chain/reorg/drop", nil) | ||
| _ = metrics.GetOrRegisterMeter("chain/reorg/invalidTx", nil) |
There was a problem hiding this comment.
@rus-alex what is the point in adding metrics, which will be unused?
There was a problem hiding this comment.
The point is to show the same set of metrics like geth. As I remember it was a one of #290 goals.
There was a problem hiding this comment.
I agree we should add as much metrics from geth as we can, however if we cannot fill the metric with any data and we create it unused, it seems useless to me - is there some usecase which needs them to be present, even through they will have no meaningful value?
There was a problem hiding this comment.
It is just method to say: we didn't forget implemented such metrics and they better than geth's.
Agreed, it is overmach.
3 participants
Here is the set of geth compatible metrics:
( it is an adaptation of #290 after #358 )