Refactoring: statedb interface#405
Open
rus-alex wants to merge 7 commits intoFantom-foundation:developfrom
Open
Refactoring: statedb interface#405rus-alex wants to merge 7 commits intoFantom-foundation:developfrom
rus-alex wants to merge 7 commits intoFantom-foundation:developfrom
Conversation
hadv
suggested changes
Dec 13, 2022
Comment on lines
141
to
144
| evmDb := gdb.EvmStore().EvmDb | ||
| if evmDb == nil { | ||
| panic("unknown EvmDb format") | ||
| } |
Contributor
There was a problem hiding this comment.
We might wrap these into a function in evmstore.Store to avoid duplicate code?
Contributor
Author
There was a problem hiding this comment.
Better I will add different error messages which explain each case.
cyberbono3
approved these changes
Dec 13, 2022
hadv
approved these changes
Dec 13, 2022
JekaMas
reviewed
Jan 19, 2023
| return nil, err | ||
| } | ||
|
|
||
| state, ok := evmcore.IsMptStateDB(statedb) |
There was a problem hiding this comment.
Sorry for asking, was just looking into the code and the consensus and found PRs.
How do you think, does it worth it to use generics+interfaces here to get rid of type assertion and have more strict type checks?
Contributor
Author
There was a problem hiding this comment.
It will be an over-engineering for now. All we need is check here does the proofs complies with the legacy format.
We should not return others kind of proofs because clients understand the legacy (MPT) only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces exact
state.StateDBstruct with more generalevmcore.StateDBinterface.This is necessary for easier maintain go-opera on different state db implementation (flat, erigon, etc.).