Remove redundant DefaultDataDir call#500
Open
holisticode wants to merge 4 commits intoFantom-foundation:developfrom
Open
Remove redundant DefaultDataDir call#500holisticode wants to merge 4 commits intoFantom-foundation:developfrom
holisticode wants to merge 4 commits intoFantom-foundation:developfrom
Conversation
rus-alex
approved these changes
Aug 12, 2023
Contributor
rus-alex
left a comment
rus-alex
left a comment
There was a problem hiding this comment.
Why don't you refactor this part totally along with it?
Existence of defaultNodeConfig() and NodeDefaultConfig at the same time is confusing. Let's replace them with single DefaultNodeConfig() for example.
Author
|
@rus-alex refactored according to your suggestion |
rus-alex
reviewed
Aug 15, 2023
cmd/opera/launcher/defaults.go
Outdated
| @@ -28,22 +29,27 @@ func overrideFlags() { | |||
| } | |||
|
|
|||
| // NodeDefaultConfig contains reasonable default settings. | |||
Contributor
There was a problem hiding this comment.
Godoc agreement: the comment should begins with the name of the element it describes.
Author
There was a problem hiding this comment.
Updated and also fixed tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DefaultDataDir()call is already assigned in theNodeDefaultConfigglobal variable on line 32 indefaults.go