Initialize speed and position with float constants#658
Merged
eleurent merged 1 commit intoFarama-Foundation:masterfrom Aug 29, 2025
Merged
Initialize speed and position with float constants#658eleurent merged 1 commit intoFarama-Foundation:masterfrom
eleurent merged 1 commit intoFarama-Foundation:masterfrom
Conversation
eleurent
approved these changes
Aug 28, 2025
Ensure that speed and position are initialized using floating-point values. This prevents vectorized environment wrappers from inferring an integer dtype when a single environment resets, which could otherwise cause loss of precision.
Contributor
Author
|
Amended vec env test so that envs without a duration config will also terminate |
Collaborator
|
Thanks a lot for the change and for fixing the test! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that speed and position are initialized using floating-point values. This prevents vectorized environment wrappers from inferring an integer dtype when a single environment resets, which could otherwise cause loss of precision.