Fix divide by zero warning in LidarObservation#661
Open
dhruvildarji wants to merge 1 commit intoFarama-Foundation:masterfrom
Open
Fix divide by zero warning in LidarObservation#661dhruvildarji wants to merge 1 commit intoFarama-Foundation:masterfrom
dhruvildarji wants to merge 1 commit intoFarama-Foundation:masterfrom
Conversation
Replace the epsilon-based workaround in `distance_to_rect` with `np.errstate(divide="ignore", invalid="ignore")` to properly suppress the RuntimeWarning. The previous `eps = 1e-6` offset was insufficient because `(q - r) @ v` could equal exactly `-eps`, still producing a zero denominator. When the denominator is zero the ray is parallel to that rectangle edge, so the resulting inf values correctly cause the interval check to fail and return `np.inf` (no intersection). Fixes Farama-Foundation#655
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeWarning: divide by zero encountered in scalar divideindistance_to_rect()used by LidarObservationeps = 1e-6offset withnp.errstate(divide="ignore", invalid="ignore")to properly suppress the warninginfvalues correctly cause the interval intersection check to fail, returningnp.inf(no intersection) — preserving existing mathematical behaviorTest plan
RuntimeWarning: divide by zero encountered in scalar dividenp.infFixes #655