fix: add emptiness check for linger.ms and statistics.interval.ms#712
Open
mbaturin-rubbi wants to merge 1 commit intoFarfetch:masterfrom
Open
fix: add emptiness check for linger.ms and statistics.interval.ms#712mbaturin-rubbi wants to merge 1 commit intoFarfetch:masterfrom
mbaturin-rubbi wants to merge 1 commit intoFarfetch:masterfrom
Conversation
…ore overriding ProducerConfig value
mbaturin-rubbi
force-pushed
the
respect-producer-config
branch
from
45d25b6 to
691aed8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a null check for
_lingerMsand_statisticsIntervalbefore overriding_producerConfig.LingerMsand_producerConfig.StatisticsIntervalMsto avoid overwriting original values with empty ones.Fixes #711
How Has This Been Tested?
NuGet package was built and tested in an application where
linger.msandstatistics.interval.mswere provided inProducerConfigChecklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement