Bug Fix: This fix makes the component stop failing silently when user doesn't specify onFail prop#885
Open
skbergam wants to merge 1 commit intoFaridSafi:masterfrom
Open
Bug Fix: This fix makes the component stop failing silently when user doesn't specify onFail prop#885skbergam wants to merge 1 commit intoFaridSafi:masterfrom
skbergam wants to merge 1 commit intoFaridSafi:masterfrom
Conversation
This way, the default onFail behavior will occur for users who don't specify one (currently, the default behavior of calling `console.warn` isn't reachable code). I spent 2 hours trying to figure out why it was silently failing. Had to manually edit the code locally to figure out the issue (my API key had restrictions) but had this PR already been in place it would've taken seconds. Hopefully this helps someone else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, the default onFail behavior will occur for users who don't specify one (currently, the default behavior of calling
console.warnisn't reachable code).I spent 2 hours trying to figure out why it was silently failing. Had to manually edit the code locally to figure out the issue (my API key had restrictions) but had this PR already been in place it would've taken seconds. Hopefully this helps someone else.