fix: respect keyboardShouldPersistTaps in FlatList#993
Open
n-kulic wants to merge 1 commit intoFaridSafi:masterfrom
Open
fix: respect keyboardShouldPersistTaps in FlatList#993n-kulic wants to merge 1 commit intoFaridSafi:masterfrom
n-kulic wants to merge 1 commit intoFaridSafi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onPress not called on first tap in GooglePlacesAutocomplete
What's the issue?
The internal
FlatListnever forwardskeyboardShouldPersistTaps, so even if caller sets it to'handled'or'always', the first tap always closes the keyboard without firingonPress.How to reproduce?
Type any query and tap a result -> keyboard hides, item is not selected until you tap again.
Proposed changes
Pass component's
keyboardShouldPersistTapsprop to the FlatList:Now the list respects the prop (defaults to 'always'), so first tap hits the row immediately.