Clean up repository structure and fix code issues#6
Open
FarisHijazi wants to merge 1 commit intomasterfrom
Open
Clean up repository structure and fix code issues#6FarisHijazi wants to merge 1 commit intomasterfrom
FarisHijazi wants to merge 1 commit intomasterfrom
Conversation
- Fixed typo in setup.py: 'rqeuirements' -> 'requirements' - Fixed SyntaxWarning in rarbgcli.py (removed 'return' in finally block) - Updated deprecated Selenium methods (find_element_by_* -> find_element(By.*)) - Fixed deprecated chrome_options parameter to use 'options' - Cleaned up .gitignore by removing duplicate entries - Updated requirements.txt to use flexible version constraints (>= instead of ==) - Removed asyncio from requirements.txt (built-in module) - Updated Selenium requirement to 4.0.0+ for modern API compatibility These changes improve code quality, fix warnings, and ensure compatibility with current versions of dependencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Code Fixes
setup.py: changedrqeuirementstorequirementsrarbgcli.pyby removingreturnstatement from finally blockfind_element_by_*→find_element(By.*, ...)find_elements_by_*→find_elements(By.*, ...)chrome_optionsparameter →optionsDependency Updates
requirements.txtto use flexible version constraints (>=instead of==)asynciofrom requirements (it's a built-in Python module)>=4.0.0for modern API supportConfiguration Cleanup
.gitignore(.cookies.json,dist/,build/)Test Plan
🤖 Generated with Claude Code