Skip to content

Minor cleanup #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2014
Merged

Minor cleanup #125

merged 4 commits into from
Jan 25, 2014

Conversation

goncalossilva
Copy link
Contributor

While checking the code to implement #124, I found a few things that could be optimized, namely:

  1. A couple of manual array copies
  2. Usage of StringBuffer where StringBuilder would suffice, or StringBuilder where String would suffice
  3. Redundant casts

While all of this is just polish, I think there's a lot to gain from the first point, fixed in 9580482.

@goncalossilva
Use StringBuilder instead of StringBuffer
3c4f787 
Synchronization is not needed in this static context.
@goncalossilva
Remove usage of StringBuilder as it's unneeded
d1d4382 
There are no advantages here, only disadvantages.
@goncalossilva
Remove redundant casts
2bba5dd
@goncalossilva
Replace manual array copy with System.arraycopy()
9580482 
This approach is more efficient.
cowtowncoder added a commit that referenced this pull request Jan 25, 2014
@cowtowncoder
Merge pull request #125 from goncalossilva/minor_cleanup
0e791ab 
Minor cleanup
@cowtowncoder cowtowncoder merged commit 0e791ab into FasterXML:master Jan 25, 2014
@cowtowncoder
Copy link
Member

Makes sense, thanks!

@goncalossilva
Copy link
Contributor Author

No problem, happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goncalossilva @cowtowncoder