Skip to content

go back to using switch statements in schubfach code #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022
Merged

go back to using switch statements in schubfach code #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 28 additions & 39 deletions src/main/java/com/fasterxml/jackson/core/io/schubfach/DoubleToDecimal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,50 +146,39 @@ public static Appendable appendTo(double v, Appendable app)
}

private String toDecimalString(double v) {
final int intValue = toDecimal(v);
if (intValue == NON_SPECIAL) {
return charsToString();
} else if (intValue == PLUS_ZERO) {
return "0.0";
} else if (intValue == MINUS_ZERO) {
return "-0.0";
} else if (intValue == PLUS_INF) {
return "Infinity";
} else if (intValue == MINUS_INF) {
return "-Infinity";
} else {
return "NaN";
switch (toDecimal(v)) {
case NON_SPECIAL: return charsToString();
case PLUS_ZERO: return "0.0";
case MINUS_ZERO: return "-0.0";
case PLUS_INF: return "Infinity";
case MINUS_INF: return "-Infinity";
default: return "NaN";
}
}

private Appendable appendDecimalTo(double v, Appendable app)
throws IOException {
final int intValue = toDecimal(v);
if (intValue == NON_SPECIAL) {
char[] chars = new char[index + 1];
for (int i = 0; i < chars.length; ++i) {
chars[i] = (char) bytes[i];
}
if (app instanceof StringBuilder) {
return ((StringBuilder) app).append(chars);
}
if (app instanceof StringBuffer) {
return ((StringBuffer) app).append(chars);
}
for (char c : chars) {
app.append(c);
}
return app;
} else if (intValue == PLUS_ZERO) {
return app.append("0.0");
} else if (intValue == MINUS_ZERO) {
return app.append("-0.0");
} else if (intValue == PLUS_INF) {
return app.append("Infinity");
} else if (intValue == MINUS_INF) {
return app.append("-Infinity");
} else {
return app.append("NaN");
switch (toDecimal(v)) {
case NON_SPECIAL:
char[] chars = new char[index + 1];
for (int i = 0; i < chars.length; ++i) {
chars[i] = (char) bytes[i];
}
if (app instanceof StringBuilder) {
return ((StringBuilder) app).append(chars);
}
if (app instanceof StringBuffer) {
return ((StringBuffer) app).append(chars);
}
for (char c : chars) {
app.append(c);
}
return app;
case PLUS_ZERO: return app.append("0.0");
case MINUS_ZERO: return app.append("-0.0");
case PLUS_INF: return app.append("Infinity");
case MINUS_INF: return app.append("-Infinity");
default: return app.append("NaN");
}
}

Expand Down
67 changes: 28 additions & 39 deletions src/main/java/com/fasterxml/jackson/core/io/schubfach/FloatToDecimal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,50 +146,39 @@ public static Appendable appendTo(float v, Appendable app)
}

private String toDecimalString(float v) {
final int intValue = toDecimal(v);
if (intValue == NON_SPECIAL) {
return charsToString();
} else if (intValue == PLUS_ZERO) {
return "0.0";
} else if (intValue == MINUS_ZERO) {
return "-0.0";
} else if (intValue == PLUS_INF) {
return "Infinity";
} else if (intValue == MINUS_INF) {
return "-Infinity";
} else {
return "NaN";
switch (toDecimal(v)) {
case NON_SPECIAL: return charsToString();
case PLUS_ZERO: return "0.0";
case MINUS_ZERO: return "-0.0";
case PLUS_INF: return "Infinity";
case MINUS_INF: return "-Infinity";
default: return "NaN";
}
}

private Appendable appendDecimalTo(float v, Appendable app)
throws IOException {
final int intValue = toDecimal(v);
if (intValue == NON_SPECIAL) {
char[] chars = new char[index + 1];
for (int i = 0; i < chars.length; ++i) {
chars[i] = (char) bytes[i];
}
if (app instanceof StringBuilder) {
return ((StringBuilder) app).append(chars);
}
if (app instanceof StringBuffer) {
return ((StringBuffer) app).append(chars);
}
for (char c : chars) {
app.append(c);
}
return app;
} else if (intValue == PLUS_ZERO) {
return app.append("0.0");
} else if (intValue == MINUS_ZERO) {
return app.append("-0.0");
} else if (intValue == PLUS_INF) {
return app.append("Infinity");
} else if (intValue == MINUS_INF) {
return app.append("-Infinity");
} else {
return app.append("NaN");
switch (toDecimal(v)) {
case NON_SPECIAL:
char[] chars = new char[index + 1];
for (int i = 0; i < chars.length; ++i) {
chars[i] = (char) bytes[i];
}
if (app instanceof StringBuilder) {
return ((StringBuilder) app).append(chars);
}
if (app instanceof StringBuffer) {
return ((StringBuffer) app).append(chars);
}
for (char c : chars) {
app.append(c);
}
return app;
case PLUS_ZERO: return app.append("0.0");
case MINUS_ZERO: return app.append("-0.0");
case PLUS_INF: return app.append("Infinity");
case MINUS_INF: return app.append("-Infinity");
default: return app.append("NaN");
}
}

Expand Down