Builder-based POJO deserializer should pass builder instance, not type, to handleUnknownVanilla()
#2415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok thank you for submitting things. I will have a look, seems legit, just want to make sure I understand. |
|
Ok. Took me a while to check since there are other methods where argument is "beanOrType", but I think you are right in that in this case this should not be the case. It might be necessary in future to split method in 2 (that is, separate for builder- / non-builder cases), but for now I think fix makes sense. I will merge this manually since I'll want it in 2.10 and will add minor renaming. |
cowtowncoder
changed the title
handleUnknownVanilla()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are hitting #822 too. What we observe is that
handleUnknownVanillais called with the bulider type instead of the instance, when the builder has constructor with parameters.