Skip to content

Builder-based POJO deserializer should pass builder instance, not type, to handleUnknownVanilla() #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Builder-based POJO deserializer should pass builder instance, not type, to handleUnknownVanilla() #2415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/fasterxml/jackson/databind/deser/BuilderBasedDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ protected final Object _deserialize(JsonParser p,
return _handleUnexpectedWithin(p, ctxt, builder);
}
p.nextToken();
handleUnknownVanilla(p, ctxt, handledType(), p.currentName());
handleUnknownVanilla(p, ctxt, builder, p.currentName());
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/fasterxml/jackson/databind/deser/builder/BuilderSimpleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,9 @@ static class ValueBuilder822
public int x;
private Map<String,Object> stuff = new HashMap<String,Object>();

public ValueBuilder822 withX(int x0) {
@JsonCreator
public ValueBuilder822(@JsonProperty("x") int x0) {
this.x = x0;
return this;
}

@JsonAnySetter
Expand Down