Skip to content

Fixes jackson-module-paranamer issue 5 problem with paranamer + PropertyNamingStrategy #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2014
Merged

Fixes jackson-module-paranamer issue 5 problem with paranamer + PropertyNamingStrategy #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,16 +700,8 @@ protected void _renameProperties()
} else {
old.addAll(prop);
}

// replace the creatorProperty too, if there is one
if (_creatorProperties != null) {
for (int i = 0; i < _creatorProperties.size(); ++i) {
if (_creatorProperties.get(i).getInternalName().equals(prop.getInternalName())) {
_creatorProperties.set(i, prop);
break;
}
}
}
updateCreatorProperty(prop);
}
}
}
Expand Down Expand Up @@ -757,6 +749,8 @@ protected void _renameUsing(PropertyNamingStrategy naming)
} else {
old.addAll(prop);
}

updateCreatorProperty(prop);
}
}

Expand Down Expand Up @@ -858,4 +852,15 @@ private PropertyNamingStrategy _findNamingStrategy()
return (PropertyNamingStrategy) ClassUtil.createInstance(namingClass,
_config.canOverrideAccessModifiers());
}

private void updateCreatorProperty(POJOPropertyBuilder prop) {
if (_creatorProperties != null) {
for (int i = 0; i < _creatorProperties.size(); ++i) {
if (_creatorProperties.get(i).getInternalName().equals(prop.getInternalName())) {
_creatorProperties.set(i, prop);
break;
}
}
}
}
}