[JSTEP-10] Migrate to JUnit 5 of part 2
#705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok this did not merge cleanly from part 1. Lots of merge conflict work now. Going forward maybe we should avoid/reduce changes to import clean up; it's tons of work with limited return on investment. Especially since I need to clean merge conflicts first wrt 2.19 in which I merged part 1 but ALSO to |
…te-to-junit5-part-2
cowtowncoder
approved these changes
Jan 15, 2025
Sorry about that 🥲. Yeah merging into master and stuff should be lots of work. Will do! |
|
Phew! Now merged to |
|
Thank you so much @cowtowncoder!!! 🥲 |
JooHyukKim
deleted the
JooHyukKim-joohyukkim/2.19/547-jstep10-migrate-to-junit5-part-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #700
blocked by #704