Skip to content

Fix #569: incorrect overflow reporting #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025
Merged

Fix #569: incorrect overflow reporting #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0980876
Fix #569: incorrect overflow reporting
cowtowncoder Mar 20, 2025
432b26c
Actual fix... :)
cowtowncoder Mar 20, 2025
b265efa
...
cowtowncoder Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ion/src/main/java/com/fasterxml/jackson/dataformat/ion/IonParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,8 @@ private long _getLongValue() throws IOException {
try {
if (this.getNumberType() == NumberType.BIG_INTEGER) {
BigInteger bigInteger = _reader.bigIntegerValue();
if (BI_MIN_INT.compareTo(bigInteger) > 0 || BI_MAX_INT.compareTo(bigInteger) < 0) {
this.reportOverflowLong();
if (BI_MIN_LONG.compareTo(bigInteger) > 0 || BI_MAX_LONG.compareTo(bigInteger) < 0) {
reportOverflowLong();
}
return bigInteger.longValue();
} else {
Expand Down
13 changes: 13 additions & 0 deletions ion/src/test/java/com/fasterxml/jackson/dataformat/ion/IonNumberOverflowTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import org.hamcrest.Matchers;
import org.junit.Test;

import com.fasterxml.jackson.core.JsonParser;
import com.fasterxml.jackson.core.JsonToken;
import com.fasterxml.jackson.core.exc.InputCoercionException;

import static org.hamcrest.MatcherAssert.assertThat;
Expand Down Expand Up @@ -72,4 +74,15 @@ private void _testLongCoercionFail(BigInteger input) throws Exception
}
}

// [dataformats-binary#569]: incorrect overflow fail for long values (from BigInteger)
@Test
public void testLongAsBigIntegerSize() throws Exception {
// Note: Values: Long.MAX_VALUE through Long.MAX_VALUE -7 are considered LONG by Ion.
BigInteger bigIntLongValue = new BigInteger(Long.MAX_VALUE + "").subtract(BigInteger.TEN);
IonParser bigIntLongParser = (IonParser) new IonFactory().createParser(bigIntLongValue.toString());
assertEquals(JsonToken.VALUE_NUMBER_INT, bigIntLongParser.nextToken());
assertEquals(JsonParser.NumberType.BIG_INTEGER, bigIntLongParser.getNumberType());
assertEquals(JsonParser.NumberTypeFP.UNKNOWN, bigIntLongParser.getNumberTypeFP());
assertEquals(bigIntLongValue.longValue(), bigIntLongParser.getLongValue());
}
}
1 change: 0 additions & 1 deletion ...st/java/com/fasterxml/jackson/dataformat/ion/fuzz/IonFuzz_469_66149_NegArraySizeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import com.fasterxml.jackson.core.exc.StreamReadException;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.ion.*;
import com.fasterxml.jackson.dataformat.ion.fuzz.IonFuzzTestUtil;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.fail;
Expand Down
1 change: 0 additions & 1 deletion .../java/com/fasterxml/jackson/dataformat/ion/fuzz/IonFuzz_471_66141_AssertionErrorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import com.fasterxml.jackson.core.exc.StreamReadException;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.ion.*;
import com.fasterxml.jackson.dataformat.ion.fuzz.IonFuzzTestUtil;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.fail;
Expand Down
3 changes: 3 additions & 0 deletions release-notes/VERSION-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ Active maintainers:

2.18.4 (not yet released)

#569: (ion) `IonParser` fails to parse some `long` values saying
they are out of range when they are not
(reported, fix suggested by @seadbrane)
- (ion) Upgrade `ion-java` to 1.11.10 (from 1.11.9)

2.18.3 (28-Feb-2025)
Expand Down