Skip to content

Bugfix: Flaky test in IonValueDeserializerTest #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Bugfix: Flaky test in IonValueDeserializerTest #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ion/src/test/java/tools/jackson/dataformat/ion/ionvalue/IonValueDeserializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package tools.jackson.dataformat.ion.ionvalue;

import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
import java.util.Objects;

Expand All @@ -22,7 +22,7 @@

public class IonValueDeserializerTest {
private static class Data<T> {
private final Map<String, T> map = new HashMap<>();
private final Map<String, T> map = new LinkedHashMap<>();

protected Data() { }

Expand Down Expand Up @@ -202,7 +202,6 @@ public void shouldBeAbleToSerializeAndDeserializeIonValueDataWithIncludeNonNull(
incl -> incl.withValueInclusion(JsonInclude.Include.NON_NULL)
.withContentInclusion(JsonInclude.Include.NON_NULL))
.build();

String data = mapper.writeValueAsString(source);
assertEquals("{a:1,b:null}", data);
// Now remove the null element for the comparison below.
Expand Down