Skip to content

CsvSchema.getColumnDesc() returns unpaired square bracket when columns are empty #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2021
Merged

CsvSchema.getColumnDesc() returns unpaired square bracket when columns are empty #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions csv/src/main/java/com/fasterxml/jackson/dataformat/csv/CsvSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,10 +1456,9 @@ public Column column(String name, int probableIndex) {
public String getColumnDesc()
{
StringBuilder sb = new StringBuilder(100);
sb.append('[');
for (Column col : _columns) {
if (sb.length() == 0) {
sb.append('[');
} else {
if (sb.length() > 1) {
sb.append(',');
}
sb.append('"');
Expand Down
6 changes: 6 additions & 0 deletions csv/src/test/java/com/fasterxml/jackson/dataformat/csv/schema/CsvSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,12 @@ public void testReorderWithComparator() throws Exception
_verifyLinks(schema);
}

public void testColumnDescForEmptyScheme() throws Exception
{
CsvSchema schema = CsvSchema.emptySchema();
assertEquals("[]", schema.getColumnDesc());
}

private void _verifyLinks(CsvSchema schema)
{
List<Column> all = new ArrayList<Column>();
Expand Down