Enhanced profile for maven enhanced tests#167
Enhanced profile for maven enhanced tests#167hurelhuyag wants to merge 5 commits intoFasterXML:2.xfrom
Conversation
|
Could you please describe what is the goal here; why is the addition needed? |
|
@cowtowncoder Compile time enhancement is an important option. Those commits confirmed the project does not work with compile-time enhanced entities. Now I'm trying to understand how this project works. As far as I know, |
|
@hurelhuyag Ok, typically all PRs should have descriptions explaining the rationale which is why I asked. So it's to add verification of working (or not as the case is) of compile-time enhanced entities. That makes sense. I can't really merge this while things are failing as it's not possible to verify regressions. |
|
@cowtowncoder I am not sure about a separate workflow. This should work fine. - name: Build
run: ./mvnw -B -q -ff -ntp verify
- name: Build With Enhancement
run: ./mvnw -Penhanced -B -q -ff -ntp verify |
|
@hurelhuyag Yes but I will not merge changes to CI that would prevent "all green". So verification can only be added to main workflow when it passes. I would be ok with separate workflow that would be failing, just not |
No description provided.