-
Notifications
You must be signed in to change notification settings - Fork 23
Move jackson-datatype-money module from zalando #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
abaf36d
Migrating Commit 7fd4c1e from zalando/jackson-datatype-money
sri-adarsh-kumar 8d99b6d
Respond to review comments
sri-adarsh-kumar 487cbf9
Move Money.md in from source repo
sri-adarsh-kumar f347a4c
Use hand-crafted moditect date and change ObjectMapper in test
sri-adarsh-kumar 90bd5ae
Rename MoneyModule, use addModule in ReadMe, update License year
sri-adarsh-kumar 5fa5d6a
Remove strict Moneta dependency, Update docs
sri-adarsh-kumar bc9ab3a
Add WIP Moneta Module
sri-adarsh-kumar 4df053d
Add WIP Moneta Module
sri-adarsh-kumar 01ef594
Merge branch '2.19' into 2.19
cowtowncoder 3d34f47
Add WIP Moneta Module
sri-adarsh-kumar 4a6a7fc
Merge branch '2.19' of https://github.com/sri-adarsh-kumar/jackson-da…
sri-adarsh-kumar cf26624
Review docs
sri-adarsh-kumar a8c7b2e
Update parent README
sri-adarsh-kumar 6948585
Use SPI for MonetaryAmountFactory
sri-adarsh-kumar ed52822
Deserialize MonetaryAmount with Amount Factory
sri-adarsh-kumar 7e75b5f
Migrate Javax Money and Moneta modules to Junit 5
sri-adarsh-kumar 90a4850
Support for Moneta types moved from Javax to Moneta Module
sri-adarsh-kumar 045a019
Remove Amount Factory from MonetaModule
sri-adarsh-kumar 8cded1d
Remove CurrencyUnit deserializing from MonetaModule
sri-adarsh-kumar ac80e2a
Merge branch '2.19' into 2.19
cowtowncoder a1978c2
Fix typo in Moneta Readme
sri-adarsh-kumar 9fb4b7e
Bit of refactoring
cowtowncoder 1455f75
Fixing things wrt refactoring
cowtowncoder cdcc25a
Merge branch '2.19' into 2.19
cowtowncoder 1945ac3
minor reording of README
cowtowncoder b6ca468
Merge branch '2.19' of github.com:sri-adarsh-kumar/jackson-datatypes-…
cowtowncoder a47a085
Merge branch '2.19' into 2.19
cowtowncoder 7b8cfb3
Minor to fix to `module-info.java`s
cowtowncoder 4c2fd28
Minor fixes to READMEs
cowtowncoder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| # Representing Money in JSON | ||
|
|
||
| > A large proportion of the computers in this world manipulate money, so it's always puzzled me that money isn't actually a first class data type in any mainstream programming language. | ||
| > | ||
| > [Martin Fowler](https://martinfowler.com/eaaCatalog/money.html) | ||
|
|
||
| Unfortunately JSON is no different. This document tries to change that by proposing and comparing different styles to represent money, some inspired by external sources and some based on our own experience. | ||
|
|
||
| ## ⚠️ Monetary amounts ≠ floats | ||
|
|
||
| Before we dive into details, always keep the following in mind. However you desire to format money in JSON, nothing changes the fact that you should... | ||
|
|
||
| > **Never hold monetary values [..] in a float variable.** Floating point is not suitable for this work, and you must use either [fixed-point](#fixed-point) or [decimal](#decimal) values. | ||
| > | ||
| > [Coinkite: Common Terms and Data Objects](https://web.archive.org/web/20150924073850/https://docs.coinkite.com/api/common.html) | ||
|
|
||
| ## Styles | ||
|
|
||
| We identified the following styles that all of different advantages and disadvantages that are discussed in their respective section. | ||
|
|
||
| | Style | Expressive | Arithmetic | Pitfalls / Misuses | | ||
| |------------------------------------|------------|------------|--------------------| | ||
| | [Decimal](#decimal) | ✔ | ✔ | Precision | | ||
| | [Quoted Decimal](#quoted-decimal) | ✔ | ✘ | Parsing | | ||
| | [Fixed Point](#fixed-point) | ✘ | ✔ | Mixed scales | | ||
| | [Mixed](#mixed) | ✘ | ✔ | Consistency | | ||
|
|
||
| ### Decimal | ||
|
|
||
| The most straightforward way to represent a monetary amount would be a base-10 decimal number: | ||
|
|
||
| ```json | ||
| { | ||
| "amount": 49.95, | ||
| "currency": "EUR" | ||
| } | ||
| ``` | ||
|
|
||
| It's expressive, readable and allows arithmetic operations. The downside is that most [JSON decoders will treat it as a floating point](https://tools.ietf.org/html/rfc7159#section-6) number which is very much undesirable. | ||
|
|
||
| Most programming languages have support for arbitrary-precision [decimals](#decimal-implementations) and JSON decoders that can be configured to use them. In general it can be considered to be a problem of the implementation, not the format itself. | ||
|
|
||
| ### Quoted Decimal | ||
|
|
||
| Same as [Decimal](#decimal) but quoted so your JSON decoder treats it as a string: | ||
|
|
||
| ```json | ||
| { | ||
| "amount": "49.95", | ||
| "currency": "EUR" | ||
| } | ||
| ``` | ||
|
|
||
| It solves the precision problem of decimals on the expense of performing arithmetic operations on it. It also requires a two-phase parsing, i.e. parsing the JSON text into a data structure and then parsing quoted amounts into decimals. | ||
|
|
||
| ### Fixed Point | ||
|
|
||
| > A value of a fixed-point data type is essentially an integer that is scaled by an implicit specific factor determined by the type. | ||
| > | ||
| > [Wikipedia: Fixed-point arithmetic](https://en.wikipedia.org/wiki/Fixed-point_arithmetic) | ||
|
|
||
| ```json | ||
| { | ||
| "amount": 4995, | ||
| "currency": "EUR" | ||
| } | ||
| ``` | ||
|
|
||
| The implicit scaling factor is defined as (0.1 raised to the power of) the currency's [default number of fraction digits](http://www.localeplanet.com/icu/currency.html). | ||
|
|
||
| In rare cases one might need a higher precision, e.g. to have sub-cent. In this case the scale can be defined explicitly: | ||
|
|
||
| ```json | ||
| { | ||
| "amount": 499599, | ||
| "currency": "EUR", | ||
| "scale": 4 | ||
| } | ||
| ``` | ||
|
|
||
| The downside with fixed-point amounts is that reading them is a bit harder and arithmetic with mixed scale amounts can be tricky and error-prone. | ||
|
|
||
| ### Mixed | ||
|
|
||
| As a way to counter all negative aspects of the styles above one idea would be to have a single object that contains all of the formats: | ||
|
|
||
| ```json | ||
| { | ||
| "decimal": 49.95, | ||
| "quoted_decimal": "49.95", | ||
| "fixed_point": 4995, | ||
| "scale": 2, | ||
| "currency": "EUR" | ||
| } | ||
| ``` | ||
|
|
||
| Decoders can choose the representation that fits them the best. Encoders on the other hand have the harder task by providing all of them and making sure that all values are in fact consistent. | ||
|
|
||
| ## Decimal Implementations | ||
|
|
||
| | Language | Implementation | | ||
| |------------|---------------------------------------------------------------------------------------------| | ||
| | C# | [decimal](https://msdn.microsoft.com/en-us/library/364x0z75.aspx) | | ||
| | Java | [java.math.BigDecimal](https://docs.oracle.com/javase/8/docs/api/java/math/BigDecimal.html) | | ||
| | JavaScript | [decimal.js](https://github.com/MikeMcl/decimal.js/) | | ||
| | Python | [decimal.Decimal](https://docs.python.org/2/library/decimal.html) | | ||
|
|
||
| ## Credits and References | ||
|
|
||
| - [Coinkite: Currency Amounts](https://web.archive.org/web/20150924073850/https://docs.coinkite.com/api/common.html#currency-amounts) | ||
| - [Culttt: How to handle money and currency in web applications](http://culttt.com/2014/05/28/handle-money-currency-web-applications/) | ||
| - [Currency codes - ISO 4217](https://www.iso.org/iso-4217-currency-codes.html) | ||
| - [LocalePlanet: ICU Currencies](http://www.localeplanet.com/icu/currency.html) | ||
| - [RFC 7159: The JavaScript Object Notation (JSON) Data Interchange Format](https://tools.ietf.org/html/rfc7159#section-6) | ||
| - [Stackoverflow: What is the standard for formatting currency values in JSON?](http://stackoverflow.com/questions/30249406/what-is-the-standard-for-formatting-currency-values-in-json) | ||
| - [Stackoverflow: Why not use Double or Float to represent currency?](http://stackoverflow.com/questions/3730019/why-not-use-double-or-float-to-represent-currency/3730040#3730040) | ||
| - [TechEmpower: Mangling JSON numbers](https://www.techempower.com/blog/2016/07/05/mangling-json-numbers/) | ||
| - [Wikipedia: Fixed-point arithmetic](https://en.wikipedia.org/wiki/Fixed-point_arithmetic) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,214 @@ | ||
| # Jackson Datatype Money | ||
|
|
||
| *Jackson Datatype Money* is a [Jackson](https://github.com/codehaus/jackson) module to support JSON serialization and | ||
| deserialization of [JavaMoney](https://github.com/JavaMoney/jsr354-api) data types. It fills a niche, in that it | ||
| integrates JavaMoney and Jackson so that they work seamlessly together, without requiring additional | ||
| developer effort. In doing so, it aims to perform a small but repetitive task — once and for all. | ||
|
|
||
| This library reflects an opinionated API [representation of monetary amounts in JSON](MONEY.md) | ||
|
|
||
| With this library, it is possible to represent monetary amounts in JSON as follows: | ||
|
|
||
| ```json | ||
| { | ||
| "amount": 29.95, | ||
| "currency": "EUR" | ||
| } | ||
| ``` | ||
|
|
||
| ## Features | ||
|
|
||
| - enables you to express monetary amounts in JSON | ||
| - can be used in a REST APIs | ||
| - customized field names | ||
| - localization of formatted monetary amounts | ||
| - allows you to implement RESTful API endpoints that format monetary amounts based on the Accept-Language header | ||
| - is unique and flexible | ||
|
|
||
| ## Dependencies | ||
|
|
||
| - Java 8 or higher | ||
| - Any build tool using Maven Central, or direct download | ||
| - Jackson | ||
| - JavaMoney | ||
|
|
||
| ## Installation | ||
|
|
||
| Add the following dependency to your project: | ||
|
|
||
| ```xml | ||
|
|
||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.datatype</groupId> | ||
| <artifactId>jackson-datatype-money</artifactId> | ||
| <version>${jackson-datatype-money.version}</version> | ||
| </dependency> | ||
| ``` | ||
|
|
||
| For ultimate flexibility, this module is compatible with the official version as well as the backport of JavaMoney. The | ||
| actual version will be selected by a profile based on the current JDK version. | ||
|
|
||
| ## Configuration | ||
|
|
||
| Register the module with your `ObjectMapper`: | ||
|
|
||
| ```java | ||
| ObjectMapper mapper = new ObjectMapper() | ||
| .registerModule(new MoneyModule()); | ||
| ``` | ||
|
|
||
| Alternatively, you can use the SPI capabilities: | ||
|
|
||
| ```java | ||
| ObjectMapper mapper = new ObjectMapper() | ||
| .findAndRegisterModules(); | ||
| ``` | ||
|
|
||
| ### Serialization | ||
|
|
||
| For serialization this module currently supports | ||
| [ | ||
| `javax.money.MonetaryAmount`](https://github.com/JavaMoney/jsr354-api/blob/master/src/main/java/javax/money/MonetaryAmount.java) | ||
| and will, by default, serialize it as: | ||
|
|
||
| ```json | ||
| { | ||
| "amount": 99.95, | ||
| "currency": "EUR" | ||
| } | ||
| ``` | ||
|
|
||
| To serialize number as a JSON string, you have to configure the quoted decimal number value serializer: | ||
|
|
||
| ```java | ||
| ObjectMapper mapper = new ObjectMapper() | ||
| .registerModule(new MoneyModule().withQuotedDecimalNumbers()); | ||
|
||
| ``` | ||
|
|
||
| ```json | ||
| { | ||
| "amount": "99.95", | ||
| "currency": "EUR" | ||
| } | ||
| ``` | ||
|
|
||
| ### Formatting | ||
|
|
||
| A special feature for serializing monetary amounts is *formatting*, which is **disabled by default**. To enable it, you | ||
| have to either enable default formatting: | ||
|
|
||
| ```java | ||
| ObjectMapper mapper = new ObjectMapper() | ||
| .registerModule(new MoneyModule().withDefaultFormatting()); | ||
| ``` | ||
|
|
||
| ... or pass in a `MonetaryAmountFormatFactory` implementation to the `MoneyModule`: | ||
|
|
||
| ```java | ||
| ObjectMapper mapper = new ObjectMapper() | ||
| .registerModule(new MoneyModule() | ||
| .withFormatting(new CustomMonetaryAmountFormatFactory())); | ||
| ``` | ||
|
|
||
| The default formatting delegates directly to `MonetaryFormats.getAmountFormat(Locale, String...)`. | ||
|
|
||
| Formatting only affects the serialization and can be customized based on the *current* locale, as defined by the | ||
| [ | ||
| `SerializationConfig`](https://fasterxml.github.io/jackson-databind/javadoc/2.0.0/com/fasterxml/jackson/databind/SerializationConfig.html#with\(java.util.Locale\)). | ||
| This allows to implement RESTful API endpoints | ||
| that format monetary amounts based on the `Accept-Language` header. | ||
|
|
||
| The first example serializes a monetary amount using the `de_DE` locale: | ||
|
|
||
| ```java | ||
| ObjectWriter writer = mapper.writer().with(Locale.GERMANY); | ||
| writer. | ||
|
|
||
| writeValueAsString(Money.of(29.95, "EUR")); | ||
| ``` | ||
|
|
||
| ```json | ||
| { | ||
| "amount": 29.95, | ||
| "currency": "EUR", | ||
| "formatted": "29,95 EUR" | ||
| } | ||
| ``` | ||
|
|
||
| The following example uses `en_US`: | ||
|
|
||
| ```java | ||
| ObjectWriter writer = mapper.writer().with(Locale.US); | ||
| writer. | ||
|
|
||
| writeValueAsString(Money.of(29.95, "USD")); | ||
| ``` | ||
|
|
||
| ```json | ||
| { | ||
| "amount": 29.95, | ||
| "currency": "USD", | ||
| "formatted": "USD29.95" | ||
| } | ||
| ``` | ||
|
|
||
| More sophisticated formatting rules can be supported by implementing `MonetaryAmountFormatFactory` directly. | ||
|
|
||
| ### Deserialization | ||
|
|
||
| This module will use `org.javamoney.moneta.Money` as an implementation for `javax.money.MonetaryAmount` by default when | ||
| deserializing money values. If you need a different implementation, you can pass a different `MonetaryAmountFactory` | ||
| to the `MoneyModule`: | ||
|
|
||
| ```java | ||
| ObjectMapper mapper = new ObjectMapper() | ||
| .registerModule(new MoneyModule() | ||
| .withMonetaryAmount(new CustomMonetaryAmountFactory())); | ||
| ``` | ||
|
|
||
| You can also pass in a method reference: | ||
|
|
||
| ```java | ||
| ObjectMapper mapper = new ObjectMapper() | ||
| .registerModule(new MoneyModule() | ||
| .withMonetaryAmount(FastMoney::of)); | ||
| ``` | ||
|
|
||
| *Jackson Datatype Money* comes with support for all `MonetaryAmount` implementations from Moneta, the reference | ||
| implementation of JavaMoney: | ||
|
|
||
| | `MonetaryAmount` Implementation | Factory | | ||
| |-------------------------------------|-----------------------------------------------------------------------------------------------------------------------| | ||
| | `org.javamoney.moneta.FastMoney` | [`new MoneyModule().withFastMoney()`](src/main/java/com/fasterxml/jackson/datatype/money/FastMoneyFactory.java) | | ||
| | `org.javamoney.moneta.Money` | [`new MoneyModule().withMoney()`](src/main/java/com/fasterxml/jackson/datatype/money/MoneyFactory.java) | | ||
| | `org.javamoney.moneta.RoundedMoney` | [`new MoneyModule().withRoundedMoney()`](src/main/java/com/fasterxml/jackson/datatype/money/RoundedMoneyFactory.java) | | | ||
|
|
||
| Module supports deserialization of amount number from JSON number as well as from JSON string without any special | ||
| configuration required. | ||
|
|
||
| ### Custom Field Names | ||
|
|
||
| As you have seen in the previous examples the `MoneyModule` uses the field names `amount`, `currency` and `formatted` | ||
| by default. Those names can be overridden if desired: | ||
|
|
||
| ```java | ||
| ObjectMapper mapper = new ObjectMapper() | ||
| .registerModule(new MoneyModule() | ||
| .withAmountFieldName("value") | ||
| .withCurrencyFieldName("unit") | ||
| .withFormattedFieldName("pretty")); | ||
| ``` | ||
|
|
||
| ## Usage | ||
|
|
||
| After registering and configuring the module you're now free to directly use `MonetaryAmount` in your data types: | ||
|
|
||
| ```java | ||
| import javax.money.MonetaryAmount; | ||
|
|
||
| public class Product { | ||
| private String sku; | ||
| private MonetaryAmount price; | ||
| ... | ||
| } | ||
| ``` | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change to use new-er "addModule":
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.