-
Notifications
You must be signed in to change notification settings - Fork 23
Fix #56: add plain module-info.java's #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0e64e8c
Fix #56: add plain module-info.java's
cowtowncoder dc3581b
Try to get tests working too
cowtowncoder abf8b8a
...
cowtowncoder 7310582
...
cowtowncoder fb28691
Merge branch 'master' into tatu/3.0/56-javax-money-jpms
cowtowncoder 0e101df
Merge branch 'master' into tatu/3.0/56-javax-money-jpms
cowtowncoder 08bde6e
Merge branch '3.x' into tatu/3.0/56-javax-money-jpms
cowtowncoder c0b9e28
Merge branch '3.x' into tatu/3.0/56-javax-money-jpms
cowtowncoder 4879fe1
Merge branch '3.x' into tatu/3.0/56-javax-money-jpms
cowtowncoder aa8f748
...
cowtowncoder 7e5a023
Remove Lombok from module defs
cowtowncoder 209e68b
Merge branch '3.x' into tatu/3.0/56-javax-money-jpms
cowtowncoder 3f3eac9
manual merge of pom.xml change
cowtowncoder a51c974
update release notes
cowtowncoder b7048bf
Update Moneta's JPMS defs too
cowtowncoder c4d2037
...
cowtowncoder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
javax-money/src/main/java/tools/jackson/datatype/javax/money/MonetaryAmountDeserializer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // Javax-money module (unit) Test Module descriptor | ||
| module tools.jackson.datatype.javax.money | ||
| { | ||
| // Since we are not split from Main artifact, will not | ||
| // need to depend on Main artifact -- but need its dependencies | ||
|
|
||
| requires com.fasterxml.jackson.annotation; | ||
| requires tools.jackson.core; | ||
| requires tools.jackson.databind; | ||
|
|
||
| requires java.money; | ||
|
|
||
| // compile-time only dependencies | ||
| requires static org.apiguardian.api; | ||
| requires static lombok; | ||
|
|
||
| // Additional test lib/framework dependencies | ||
| requires org.assertj.core; | ||
| requires org.mockito; | ||
| requires org.junit.jupiter.api; | ||
| requires org.junit.jupiter.params; | ||
|
|
||
| requires org.javamoney.moneta; | ||
|
|
||
| // Further, need to open up test packages for JUnit et al | ||
| opens tools.jackson.datatype.javax.money; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per some comments, this section should no longer be needed and may even be counter-productive.
Does not seem to make any difference in this case wrt failure.