Fix feature methods #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, why roll your own integer-based bitset instead of using an |
|
At this point, it's just a cut'n pasted idiom. But back in the day the idea of using less memory (for core streaming API) was the main reason. Nothing deeper than that. |
|
Wow. Goes to show that testing of just enabling a feature won't help finding broken-ness of disabling features. Embarrassing. Thank you for the fix! I'll need to backport it as well. |
cowtowncoder
added a commit
that referenced
this pull request
Mar 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cowtowncoder I tried to use the configure method that accepts a
JaxRSFeaturebut it didn't have any effect. After banging my head against a wall for a little bit I looked inside the method and saw that it was ignoring theboolean stateparameter and just always enabled the feature. This PR updates the configure method to properly enable/disable based on the boolean parameter and also removes a bunch of extraneous boolean arguments that were also unused.