Skip to content

Conversation

@k163377
Copy link
Contributor

@k163377 k163377 commented Jun 15, 2025

@k163377 k163377 requested a review from Copilot June 15, 2025 04:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive tests to ensure both @jsonvalue and @jsonkey annotations work correctly with Kotlin inline value classes, covering primitive and object types in different usage contexts.

  • Adds tests for direct serialization and DTO property serialization with value classes annotated with @jsonvalue.
  • Adds tests for key serialization using value classes annotated with @jsonkey.
  • Covers both non-nullable and nullable cases to assert expected JSON outputs.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser/valueClass/jsonValue/TwoUnitPrimitiveTest.kt Tests for @jsonvalue with a Long value in both direct and property use.
src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser/valueClass/jsonValue/PrimitiveTest.kt Tests for @jsonvalue with an Int value handling non-null and nullable cases.
src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser/valueClass/jsonValue/NullablePrimitiveTest.kt Tests for @jsonvalue with a nullable primitive value.
src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser/valueClass/jsonValue/NullableObjectTest.kt Tests for @jsonvalue with a nullable String object.
src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser/valueClass/jsonValue/NonNullObjectTest.kt Tests for @jsonvalue with a non-nullable String object and its nullable variant.
src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser/valueClass/jsonKey/TwoUnitPrimitiveTest.kt Tests for @jsonkey with a Long value validating key serialization.
src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser/valueClass/jsonKey/PrimitiveTest.kt Tests for @jsonkey with an Int value in key scenarios.
src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser/valueClass/jsonKey/NullablePrimitiveTest.kt Tests for @jsonkey with a nullable primitive value.
src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser/valueClass/jsonKey/NullableObjectTest.kt Tests for @jsonkey with a nullable String object as key.
src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser/valueClass/jsonKey/NonNullObjectTest.kt Tests for @jsonkey with both non-nullable and nullable String objects as keys.

@k163377 k163377 merged commit 61ea671 into FasterXML:2.19 Jun 15, 2025
15 checks passed
@k163377 k163377 deleted the porting-tests branch June 15, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant