Skip to content

Cleanup of deprecated contents #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2025
Merged

Cleanup of deprecated contents #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da7fa1a
Make ValueClassUnboxSerializer internal
k163377 Aug 30, 2025
7558cc7
Remove enabledSingletonSupport flag property
k163377 Aug 30, 2025
5705a1a
Update cmp config
k163377 Aug 30, 2025
bfec402
Update release notes wrt #1043
k163377 Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,9 @@
<excludes>
<!-- public -->
<!-- removed -->
<exclude>
com.fasterxml.jackson.module.kotlin.KotlinModule#getEnabledSingletonSupport()
</exclude>
<exclude>com.fasterxml.jackson.module.kotlin.MissingKotlinParameterException</exclude>
<!-- internal -->
<exclude>
Expand Down
1 change: 1 addition & 0 deletions release-notes/CREDITS-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Contributors:
# 2.21.0 (not yet released)

WrongWrong (@k163377)
* #1043: Cleanup of deprecated contents
* #1042: Remove old StrictNullChecks
* #1041: Remove MissingKotlinParameterException
* #1039: Update settings for 2.20
Expand Down
1 change: 1 addition & 0 deletions release-notes/VERSION-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Co-maintainers:

2.21.0 (not yet released)

#1043: Deprecated content has been cleaned up with the version upgrade.
#1042: The old StrictNullChecks backend has been removed.
This improves the throughput of deserialization slightly.
#1041: The deprecated MissingKotlinParameterException has been removed.
Expand Down
18 changes: 0 additions & 18 deletions src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,24 +48,6 @@ class KotlinModule private constructor(
val useJavaDurationConversion: Boolean = UseJavaDurationConversion.enabledByDefault,
newStrictNullChecks: Boolean = NewStrictNullChecks.enabledByDefault,
) : SimpleModule(KotlinModule::class.java.name, PackageVersion.VERSION) {
/*
* Prior to 2.18, an older Enum called SingletonSupport was used to manage feature.
* To deprecate it and replace it with singletonSupport: Boolean, the following steps are in progress.
*
* 1. add enabledSingletonSupport: Boolean property
* 2. delete SingletonSupport class and change the property to singletonSupport: Boolean
* 3. remove the enabledSingletonSupport property
*
* Now that 2 is complete, deprecation is in progress for 3.
*/
@Deprecated(
level = DeprecationLevel.ERROR,
message = "This property is scheduled to be removed in 2.21 or later" +
" in order to unify the use of KotlinFeature.",
replaceWith = ReplaceWith("singletonSupport")
)
val enabledSingletonSupport: Boolean get() = singletonSupport

// To reduce the amount of destructive changes, no properties will be added to the public.
val strictNullChecks: Boolean = if (strictNullChecks) {
if (newStrictNullChecks) {
Expand Down
6 changes: 1 addition & 5 deletions src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinSerializers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,7 @@ object ULongSerializer : StdSerializer<ULong>(ULong::class.java) {
}
}

@Deprecated(
message = "This class was published by mistake. It will be removed in `2.22.0` as it is no longer used internally.",
level = DeprecationLevel.WARNING
)
object ValueClassUnboxSerializer : StdSerializer<Any>(Any::class.java) {
internal object ValueClassUnboxSerializer : StdSerializer<Any>(Any::class.java) {
private fun readResolve(): Any = ValueClassUnboxSerializer

override fun serialize(value: Any, gen: JsonGenerator, provider: SerializerProvider) {
Expand Down