Skip to content

Conversation

dinomite
Copy link
Member

@dinomite dinomite commented Jan 1, 2021

Fixes issue #373 by throwing NullInputException if a null value is to be deserialized into a non-null field.

@dinomite dinomite marked this pull request as ready for review January 1, 2021 19:33
@dinomite
Copy link
Member Author

dinomite commented Jan 1, 2021

@rafalbednarczuk Have you signed the CLA? If not, would you fill it out and email a scan/photo of the result to info at fasterxml dot com?

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

@dinomite
Copy link
Member Author

dinomite commented Jan 1, 2021

@viartemev @cowtowncoder What do you think of this new exception type?

@dinomite dinomite self-assigned this Jan 1, 2021
@dinomite dinomite added this to the 2.12.1 milestone Jan 1, 2021
@dinomite dinomite added cla-needed PR looks good (although may also require code review), but CLA needed from submitter 2.12 labels Jan 2, 2021
@dinomite dinomite modified the milestones: 2.12.1, 2.12.2 Jan 11, 2021
@dinomite
Copy link
Member Author

dinomite commented Feb 7, 2021

@viartemev Do you think adding this new exception type make sense? https://github.com/FasterXML/jackson-module-kotlin/pull/405/files#diff-f369947c6a2c8905a906e96bae39fef763c95f5b43aee145b9120319863a1487R24

class NullInputException(msg: String) : MismatchedInputException(null, msg)

@dinomite
Copy link
Member Author

dinomite commented Feb 7, 2021

@rafalbednarczuk Have you submitted a CLA to Fasterxml?

@dinomite dinomite added the code-review-needed Label to indicate that PR (or issue with PR) looks ok but needs review before merging label Feb 7, 2021
@dinomite dinomite modified the milestones: 2.12.2, 2.13.0 May 13, 2021
@k163377
Copy link
Contributor

k163377 commented Jul 8, 2023

@rafalbednarczuk cc: @cowtowncoder
I discovered this PR while working on solving the problem.
Could you please submit a CLA?

This will allow us to post your name in the release notes, etc.
Also, if you do not submit a CLA, I will not be able to confirm whether or not there is a legal issue, which would effectively make it impossible to implement this feature.

@cowtowncoder
Copy link
Member

I don't think we have CLA from the contributor fwtw.

@cowtowncoder cowtowncoder removed the 2.12 label Jul 17, 2024
@cowtowncoder
Copy link
Member

No action in years, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-needed PR looks good (although may also require code review), but CLA needed from submitter code-review-needed Label to indicate that PR (or issue with PR) looks ok but needs review before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants