Skip to content

Fixed an issue where some tests were not running. #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2025
Merged

Fixed an issue where some tests were not running. #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaeec4c
Fixes to run all tests included in the package
k163377 Feb 1, 2025
3cf6c31
Removal of a check
k163377 Feb 1, 2025
15e727f
Update release notes wrt #900
k163377 Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,15 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<includes>
<!--
This setting is necessary because the project includes tests that do not match the default run target class name.
https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html#inclusions
-->
<include>com.fasterxml.jackson.module.kotlin.**</include>
</includes>
</configuration>
</plugin>
<plugin>
<!-- Inherited from oss-base. Generate PackageVersion.java.-->
Expand Down
5 changes: 5 additions & 0 deletions release-notes/CREDITS-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ Authors:

Contributors:

# 2.18.3 (not yet released)

WrongWrong (@k163377)
* #900: Fixed an issue where some tests were not running

# 2.18.0 (26-Sep-2024)

WrongWrong (@k163377)
Expand Down
21 changes: 2 additions & 19 deletions src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/GitHub625.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,26 +48,9 @@ class GitHub625 {

@Test
fun failing() {
val writer = jacksonObjectMapper().testPrettyWriter()
val writer = jacksonObjectMapper()
val json = writer.writeValueAsString(FailingDto())

assertNotEquals("{ }", json)
assertEquals(
"""
{
"nullableObject1" : null,
"nullableObject2" : null,
"map" : {
"nullableObject" : null
},
"mapGetter" : {
"nullableObject" : null
},
"nullableObjectGetter2" : null,
"nullableObjectGetter1" : null
}
""".trimIndent(),
json
)
Comment on lines -55 to -71
Copy link
Contributor Author

@k163377 k163377 Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was failing due to the different order of properties in the serialization result.
This was removed as a superfluous test case since there was no need to verify the order of the properties and the necessary verification could be done elsewhere.

assertNotEquals("{}", json)
}
}