Skip to content

Replace JacksonXmlRootElement used in the test with JsonRootName #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2025
Merged

Replace JacksonXmlRootElement used in the test with JsonRootName #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
877d8d9
Replace JacksonXmlRootElement used in the test with JsonRootName
k163377 Apr 13, 2025
5a53c1b
Update release notes wrt #945
k163377 Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions release-notes/CREDITS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ Authors:

Contributors:

# 3.0.0-rc3 (not yet released)
WrongWrong (@k163377)
* #945: Replace JacksonXmlRootElement used in the test with JsonRootName

# 3.0.0-rc2 (not yet released)

WrongWrong (@k163377)
Expand Down
6 changes: 3 additions & 3 deletions src/test/kotlin/tools/jackson/module/kotlin/test/github/Github153.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
package tools.jackson.module.kotlin.test.github

import com.fasterxml.jackson.annotation.JsonRootName
import tools.jackson.databind.exc.InvalidDefinitionException
import tools.jackson.dataformat.xml.XmlMapper
import tools.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper
import tools.jackson.dataformat.xml.annotation.JacksonXmlProperty
import tools.jackson.dataformat.xml.annotation.JacksonXmlRootElement
import tools.jackson.module.kotlin.kotlinModule
import tools.jackson.module.kotlin.test.expectFailure
import org.junit.jupiter.api.Test
import kotlin.test.assertEquals

class TestGithub153 {
@JacksonXmlRootElement(localName = "MyPojo")
@JsonRootName("MyPojo")
class MyPojo {
@JacksonXmlElementWrapper(localName = "elements")
@JacksonXmlProperty(localName = "element")
Expand All @@ -23,7 +23,7 @@ class TestGithub153 {
var value: String? = null
}

@JacksonXmlRootElement(localName = "MyPojo")
@JsonRootName("MyPojo")
data class MyDataPojo (
@JacksonXmlElementWrapper(localName = "elements")
@JacksonXmlProperty(localName = "element")
Expand Down
4 changes: 2 additions & 2 deletions src/test/kotlin/tools/jackson/module/kotlin/test/github/failing/Github138.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
package tools.jackson.module.kotlin.test.github.failing

import com.fasterxml.jackson.annotation.JsonIgnoreProperties
import com.fasterxml.jackson.annotation.JsonRootName
import tools.jackson.databind.exc.InvalidDefinitionException
import tools.jackson.dataformat.xml.XmlMapper
import tools.jackson.dataformat.xml.annotation.JacksonXmlProperty
import tools.jackson.dataformat.xml.annotation.JacksonXmlRootElement
import tools.jackson.dataformat.xml.annotation.JacksonXmlText
import tools.jackson.module.kotlin.readValue
import tools.jackson.module.kotlin.test.expectFailure
import tools.jackson.module.kotlin.kotlinModule
import org.junit.jupiter.api.Test

class TestGithub138 {
@JacksonXmlRootElement(localName = "sms")
@JsonRootName("sms")
@JsonIgnoreProperties(ignoreUnknown = true)
data class Sms(
@JacksonXmlProperty(localName = "Phone", isAttribute = true)
Expand Down