Skip to content

Upgrade Option support to use ReferenceType. #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Upgrade Option support to use ReferenceType. #252

wants to merge 10 commits into from

Conversation

nbauernfeind
Copy link
Member

Fixes #248. @cowtowncoder Is this what you're suggesting in the issue? Tests continue to pass.

@nbauernfeind
Copy link
Member Author

Sorry, I was wrong this does not pass tests. I'll look further.

@cowtowncoder
Copy link
Member

@nbauernfeind It's the first part yes, for recognizing Option as ReferenceType. However, actual serializer/deserializer is still needed, as there are some details that can not be generalized (basically how to create actual value instances, and access contents). For those ,AtomicReferenceSerializer and AtomicReferenceSerializer would be best sources I think.

@nbauernfeind nbauernfeind added this to the 2.7.4 milestone Apr 18, 2016
@nbauernfeind nbauernfeind force-pushed the option branch 2 times, most recently from c889d3f to c2d19ad Compare April 18, 2016 14:47
@nbauernfeind nbauernfeind mentioned this pull request Apr 19, 2016
Merged
@ieure ieure mentioned this pull request Aug 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nbauernfeind @cowtowncoder