Skip to content

Conversation

Qnzvna
Copy link
Contributor

@Qnzvna Qnzvna commented Dec 15, 2017

No description provided.

@cowtowncoder
Copy link
Member

Fix is probably good, but what would be really great would be unit test to show the problem, guard against regression. jackson-databind should have a test to copy-n-paste.

I also need to figure out how to backport this in 2.9 branch.

@Qnzvna
Copy link
Contributor Author

Qnzvna commented Dec 16, 2017

I've added tests. Backport should be straightforward, I can open PR to 2.9 branch as well if you want.

@cowtowncoder
Copy link
Member

@Qnzvna Excellent -- backport to 2.9 would be helpful.

One last thing: unless I have asked for and received CLA, one would be needed before I merge the first contribution. It can be found from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(and there'a alternate Corporate-CLA if preferable; some big companies prefer that, but majority of contributions are under individual CLA. Both are fine by us)

Usual way is to print it, fill, sign, scan and email to info at fasterxml dot com.

Apologies if this has already been done: we have accumulated about two hundred so far. :)

@cowtowncoder
Copy link
Member

Fixed via #38 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants