Skip to content

command spell#1880

Open
ArthurKun21 wants to merge 28 commits intomasterfrom
cs-refill
Open

command spell#1880
ArthurKun21 wants to merge 28 commits intomasterfrom
cs-refill

Conversation

@ArthurKun21
Copy link
Copy Markdown
Collaborator

@ArthurKun21 ArthurKun21 commented Aug 15, 2024

command spell

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

Allows the usage of command spell. Features tracking of command spell and shows warning when used up to 3 times inside the script.

Screenshots

Main Screen

image

Command Spell Screen

image


Ran out of Command Spell

Main Screen

image

Command Spell Screen

image


In use

HD-Player_FF6MtfLnSn

when ran out

firefox_0YHl9Wjg6m

when deleting the cs usage

HD-Player_iLJkt043i0

Testing

Additional context

@ArthurKun21 ArthurKun21 linked an issue Aug 15, 2024 that may be closed by this pull request
1 task
@ArthurKun21 ArthurKun21 marked this pull request as draft August 15, 2024 08:06
@ArthurKun21 ArthurKun21 deleted the cs-refill branch September 22, 2024 02:35
@ArthurKun21 ArthurKun21 removed a link to an issue Oct 30, 2024
1 task
@ArthurKun21 ArthurKun21 restored the cs-refill branch November 25, 2024 09:06
@ArthurKun21 ArthurKun21 reopened this Nov 25, 2024
@ArthurKun21 ArthurKun21 marked this pull request as ready for review November 25, 2024 10:28
@ArthurKun21

This comment was marked as outdated.

@ArthurKun21
Copy link
Copy Markdown
Collaborator Author

https://github.com/Fate-Grand-Automata/FGA/actions/runs/12022628878/artifacts/2236490656

Fix the colors to make it more distinct from one another

image

@ArthurKun21

This comment was marked as outdated.

@ArthurKun21 ArthurKun21 marked this pull request as draft December 14, 2024 00:32
@ArthurKun21

This comment was marked as outdated.

@ArthurKun21 ArthurKun21 marked this pull request as ready for review December 23, 2024 08:20
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2025

Build 335

Download the latest APK for testing here

Note

You need a GitHub account to download the APK.

This URL is valid as long as the artifact has not expired yet.

@ArthurKun21 ArthurKun21 closed this Mar 9, 2025
@ArthurKun21 ArthurKun21 deleted the cs-refill branch March 9, 2025 10:05
@ArthurKun21 ArthurKun21 restored the cs-refill branch May 13, 2025 04:11
@ArthurKun21 ArthurKun21 reopened this May 13, 2025
@ArthurKun21
Copy link
Copy Markdown
Collaborator Author

ArthurKun21 commented May 13, 2025

Last time there was a problem with ultrawide screen so I implemented the possible fix bb3f48e, but I received no further replies when I presented the fix to tester so I don't know the results. It should technically work though

@cy1366371760
Copy link
Copy Markdown

Hello, when will this be merged to main branch?

@ArthurKun21
Copy link
Copy Markdown
Collaborator Author

I don't know

@cy1366371760
Copy link
Copy Markdown

I don't know

Hi, I cloned this branch. It seemed that there are only JP and EN's command spell image. So I added a CN image and it worked smoothly. Thank you for the implementation! Here is the CN image, perhaps you can add it:
command_spell

@ArthurKun21

This comment was marked as outdated.

@cy1366371760

This comment was marked as outdated.

@ArthurKun21

This comment was marked as outdated.

@ArthurKun21
Copy link
Copy Markdown
Collaborator Author

I'm going to YOLO this one for you @cy1366371760

@cy1366371760
Copy link
Copy Markdown

I'm going to YOLO this one for you @cy1366371760

Thank you!

@ArthurKun21
Copy link
Copy Markdown
Collaborator Author

You access the alpha from here #1880 (comment) it always get autoupdated with each new build from this PR

@cy1366371760
Copy link
Copy Markdown

You access the alpha from here #1880 (comment) it always get autoupdated with each new build from this PR

Hi, today I use adb command to adjust my phone's resolution to 1280 * 720 size, and remake the screenshot. It is still runnable in my phone, and I guess it will be more robust on other devices:
command_spell

@ArthurKun21
Copy link
Copy Markdown
Collaborator Author

It is still runnable in my phone, and I guess it will be more robust on other devices:

I'm going to take your word for this and update the build with your latest template image.

Copy link
Copy Markdown
Collaborator

@reconman reconman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the HP refill option and make it so the "CS (3)" button triggers the NP charge?

I don't think anyone needs to use the HP refill option when enemy attacks area heavily randomized and most people are only interested in NP refills for Bleached Earth quests.

@ArthurKun21
Copy link
Copy Markdown
Collaborator Author

I still think it is better to show the two options even if most people would only use the NP for command spell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow CS use to refill NP Get back the feature that using CS to refill NP

3 participants