Fix Opencv Crash Region out of bounds#1958
Merged
Conversation
ArthurKun21
changed the title
ArthurKun21
force-pushed
the
prevent-checking-of-invalid-size-in-opencv
branch
from
17587ad to
cf00f76
Compare
3 tasks
Collaborator
|
Seems like this only happens with the last few app versions, so since I've updated to the newest OpenCV version. Thanks for the fix, I had no idea why it was crashing. |
wowuz
pushed a commit
to wowuz/FGA
that referenced
this pull request
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opencv Crash Region out of bounds
Pull Request Type
Related issue
Description
For some odd reason, I encountered a problem wherein when checking support's skills and it was out of frame(only the servant image was visible and it matched with the template) it would led to crash. Changing the mat to null-able resolves this issue.
Screenshots
Testing
Additional context
This is edge case but damn