replaced the deprecated clickable text#1962
Merged
Conversation
ArthurKun21
force-pushed
the
update-onboarding
branch
from
27ed9a1 to
a60855c
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug by replacing the deprecated clickable text implementation in the onboarding screens with a buildAnnotatedString-based approach.
- Replaces hardcoded URL strings in localized resource files with a placeholder to allow dynamic URL injection.
- Removes the deprecated HighlightedText component and updates OnboardingItems.kt to use a new annotated string approach.
- Updates multiple localization files to support the new URL placeholder.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/localized.xml | Updates the URL reference to use a placeholder (%s) |
| app/src/main/res/values-vi/localized.xml | Same as above, for Vietnamese localization |
| app/src/main/res/values-ko/localized.xml | Same as above, for Korean localization |
| app/src/main/res/values-ja/localized.xml | Same as above, for Japanese localization |
| app/src/main/res/values-b+zh+TW/localized.xml | Same as above, for Traditional Chinese localization |
| app/src/main/res/values-b+zh+CN/localized.xml | Same as above, for Simplified Chinese localization |
| app/src/main/java/io/github/fate_grand_automata/ui/onboarding/OnboardingItems.kt | Replaces deprecated clickable text with a new buildAnnotatedString approach |
| app/src/main/java/io/github/fate_grand_automata/ui/onboarding/HighlightedText.kt | Removes the no longer used HighlightedText component |
app/src/main/java/io/github/fate_grand_automata/ui/onboarding/OnboardingItems.kt
Show resolved
Hide resolved
app/src/main/java/io/github/fate_grand_automata/ui/onboarding/OnboardingItems.kt
Show resolved
Hide resolved
reconman
force-pushed
the
update-onboarding
branch
from
a60855c to
c529925
Compare
wowuz
pushed a commit
to wowuz/FGA
that referenced
this pull request
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced the deprecated clickable text
Pull Request Type
Related issue
Description
Replaced the deprecated clickable text in on-boarding with buildannotatedstring with linkannotation
Screenshots
Testing
Additional context